[capital] Code generation: update services and models#868
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the latest updates for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a large number of new model classes for the Capital API, apparently through code generation. While the overall structure is consistent with auto-generated code, I've found several critical and high-severity issues related to data validation and model correctness.
Most importantly, many of the ...Identification classes have a flawed constructor that fails to correctly set the type discriminator field. This will likely cause issues during object serialization.
Additionally, there are inconsistencies in property nullability definitions versus their validation logic in listInvalidProperties, and some setters for enum-like properties don't enforce the allowed values correctly.
I've added specific comments with suggestions for each issue. These should be addressed to ensure the reliability and correctness of the new models.
51f2acf to
5aeecf7
Compare
5aeecf7 to
eb20e20
Compare
7862c8c to
53d86de
Compare
53d86de to
0170694
Compare
0170694 to
4b90b43
Compare
|
|
There were some comments roughly grouped into:
These are known and expected behavior, so leaving as a comment for now to be addressed in the future. |



This PR contains the automated changes for the
capitalservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.