Skip to content

[capital] Code generation: update services and models#868

Merged
jeandersonbc merged 1 commit intomainfrom
sdk-automation/capital
Jan 26, 2026
Merged

[capital] Code generation: update services and models#868
jeandersonbc merged 1 commit intomainfrom
sdk-automation/capital

Conversation

@AdyenAutomationBot
Copy link
Collaborator

This PR contains the automated changes for the capital service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners January 15, 2026 14:41
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the latest updates for the capital service by incorporating newly generated PHP code. The changes primarily focus on expanding the API's data models to support a wider range of financial operations and international banking standards, ensuring robust and compliant capital management functionalities.

Highlights

  • New Capital API Models: Introduced a comprehensive set of new PHP models for the Capital API, covering various financial entities and operations.
  • International Bank Account Identification: Added specific local bank account identification models for Australia (AU), Brazil (BR), Canada (CA), Czech Republic (CZ), Denmark (DK), Hong Kong (HK), Hungary (HU), Norway (NO), and generic IBAN identification.
  • Disbursement and Grant Management: New models for managing disbursements, grants, grant offers, fees, and repayment information have been added, enhancing the API's capital management capabilities.
  • Error Handling and Utility Classes: Included models for standardized error responses (DefaultErrorResponseEntity, InvalidField) and core interfaces (ModelInterface) to support the new API structures.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a large number of new model classes for the Capital API, apparently through code generation. While the overall structure is consistent with auto-generated code, I've found several critical and high-severity issues related to data validation and model correctness.

Most importantly, many of the ...Identification classes have a flawed constructor that fails to correctly set the type discriminator field. This will likely cause issues during object serialization.

Additionally, there are inconsistencies in property nullability definitions versus their validation logic in listInvalidProperties, and some setters for enum-like properties don't enforce the allowed values correctly.

I've added specific comments with suggestions for each issue. These should be addressed to ensure the reliability and correctness of the new models.

@jeandersonbc jeandersonbc force-pushed the sdk-automation/capital branch from 5aeecf7 to eb20e20 Compare January 16, 2026 08:22
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/capital branch 2 times, most recently from 7862c8c to 53d86de Compare January 22, 2026 18:49
@jeandersonbc jeandersonbc force-pushed the sdk-automation/capital branch from 0170694 to 4b90b43 Compare January 26, 2026 13:03
@sonarqubecloud
Copy link

@jeandersonbc
Copy link
Contributor

There were some comments roughly grouped into:

These are known and expected behavior, so leaving as a comment for now to be addressed in the future.

@jeandersonbc jeandersonbc added this pull request to the merge queue Jan 26, 2026
Merged via the queue into main with commit 127dc01 Jan 26, 2026
14 checks passed
@jeandersonbc jeandersonbc deleted the sdk-automation/capital branch January 26, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants