V0.78.3 #658
V0.78.3 #658
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @descorp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request represents a significant upgrade, bringing the project in line with the latest create-react-native-library template and updating the underlying React Native version to 0.78.x. The changes encompass a modernization of the build system, a comprehensive overhaul of development tooling, and the application of extensive code quality fixes across the codebase.
Highlights
- React Native Version Upgrade: The project's core React Native dependency has been upgraded to version 0.78.x, ensuring compatibility with the latest platform features and improvements.
- Build System Modernization: The build infrastructure has been refactored by adopting react-native-builder-bob for Babel and Metro configurations, simplifying the development and packaging processes.
- Tooling and Code Quality Enhancements: A new flat ESLint configuration (eslint.config.mjs) and updated TypeScript settings have been introduced to enforce stricter code quality, consistency, and better type checking.
- Yarn Workspaces Adoption: The project has migrated to Yarn Workspaces for improved monorepo management, streamlining dependency handling and project structure.
- Native Module Integration Improvements: iOS Podspec and Android Gradle configurations have been updated to align with the new React Native architecture and improve native module integration.
- New Contributing Guidelines: Comprehensive CONTRIBUTING.md guidelines have been added to standardize development workflow, commit messages, and testing practices.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the project to a newer template, including dependency upgrades and configuration changes for tools like Yarn, ESLint, and Babel. The changes align the project with modern React Native development practices. I've identified a few issues: a potential security risk in the Yarn configuration, a Java version downgrade that might cause build problems, the removal of the CommonJS build target which could affect compatibility, and a minor typo in the contribution guidelines.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
descorp
force-pushed
the
v0.78.3
branch
2 times, most recently
from
2acf366 to
bd3c74e
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the project to a newer template, which includes modernizing the tooling with Yarn workspaces, updating dependencies, and improving configuration files. The changes are generally excellent and align with current best practices for React Native library development. However, I've identified one critical issue in the Android Gradle configuration where the Java compatibility version has been incorrectly downgraded, which could cause build failures.
|
2 participants
Open PR
Changes
typecheckandlintfixes tosrcfolder