-
Notifications
You must be signed in to change notification settings - Fork 42
V0.78.3 #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
V0.78.3 #658
Changes from 6 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
b499413
chore: basic config
descorp 63ed166
chore: apply lint and typecheck
descorp d4c518e
chore: add missing configuration
descorp 41e5b6a
chore: updating example project
descorp d168958
chore: add minnor missing configs
descorp 8283b9c
Merge branch 'develop' into v0.78.3
descorp 734dcac
chore: remove unnececery script
descorp f9fd03d
docs: update CONTRIBUTING.md
descorp 1de5105
docs: undo CONTRIBUTING.md
descorp c06b954
ci: fix yarn@2 compatibility
descorp 89c4715
chore: update yarn.lock
descorp 1c4e50a
ci: improve android to ubuntu
descorp 8a14c18
chore: secure example dependencies
descorp 5895702
chore: undo version template in build.gradle
descorp 20b852a
chore: add international resources in build.gradle
descorp 65aae2d
chore: enable StrictSsl
descorp 1a7618a
chore: keep minSDK to 21
descorp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # EditorConfig helps developers define and maintain consistent | ||
| # coding styles between different editors and IDEs | ||
| # editorconfig.org | ||
|
|
||
| root = true | ||
|
|
||
| [*] | ||
|
|
||
| indent_style = space | ||
| indent_size = 2 | ||
|
|
||
| end_of_line = lf | ||
| charset = utf-8 | ||
| trim_trailing_whitespace = true | ||
| insert_final_newline = true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| *.pbxproj -text | ||
| # specific for windows script files | ||
| *.bat text eol=crlf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| enableStrictSsl: false | ||
|
|
||
| nmHoistingLimits: workspaces | ||
|
|
||
| nodeLinker: node-modules | ||
|
|
||
| yarnPath: .yarn/releases/yarn-4.9.2.cjs | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| # Contributing | ||
|
|
||
| Contributions are always welcome, no matter how large or small! | ||
|
|
||
| We want this community to be friendly and respectful to each other. Please follow it in all your interactions with the project. Before contributing, please read the [code of conduct](./CODE_OF_CONDUCT.md). | ||
|
|
||
| ## Development workflow | ||
|
|
||
| This project is a monorepo managed using [Yarn workspaces](https://yarnpkg.com/features/workspaces). It contains the following packages: | ||
|
|
||
| - The library package in the root directory. | ||
| - An example app in the `example/` directory. | ||
|
|
||
| To get started with the project, run `yarn` in the root directory to install the required dependencies for each package: | ||
|
|
||
| ```sh | ||
| yarn | ||
| ``` | ||
|
|
||
| > Since the project relies on Yarn workspaces, you cannot use [`npm`](https://github.com/npm/cli) for development. | ||
| You also need to install the required ruby gems for the iOS project with [bundler](https://bundler.io/). To install the gems, run the following command in the root directory: | ||
|
|
||
| ```sh | ||
| bundle install | ||
| ``` | ||
|
|
||
| Now, you can install [CocoaPods](https://cocoapods.org/) for the iOS project. To do this, run the following command in the `example/ios` directory: | ||
|
|
||
| ```sh | ||
| bundle exec pod install | ||
| ``` | ||
|
|
||
| The [example app](/example/) demonstrates usage of the library. You need to run it to test any changes you make. | ||
|
|
||
| It is configured to use the local version of the library, so any changes you make to the library's source code will be reflected in the example app. Changes to the library's JavaScript code will be reflected in the example app without a rebuild, but native code changes will require a rebuild of the example app. | ||
|
|
||
| If you want to use Android Studio or XCode to edit the native code, you can open the `example/android` or `example/ios` directories respectively in those editors. To edit the Objective-C or Swift files, open `example/ios/ReactNativeExample.xcworkspace` in XCode and find the source files at `Pods > Development Pods > @adyen/react-native`. | ||
|
|
||
| To edit the Java or Kotlin files, open `example/android` in Android studio and find the source files at `adyen-react-native` under `Android`. | ||
|
|
||
| You can use various commands from the root directory to work with the project. | ||
|
|
||
| To start the packager: | ||
|
|
||
| ```sh | ||
| yarn example start | ||
| ``` | ||
|
|
||
| To run the example app on Android: | ||
|
|
||
| ```sh | ||
| yarn example android | ||
| ``` | ||
|
|
||
| To run the example app on iOS: | ||
|
|
||
| ```sh | ||
| yarn example ios | ||
| ``` | ||
|
|
||
| To confirm that the app is running with the new architecture, you can check the Metro logs for a message like this: | ||
|
|
||
| ```sh | ||
| Running "ReactNativeExample" with {"fabric":true,"initialProps":{"concurrentRoot":true},"rootTag":1} | ||
| ``` | ||
|
|
||
| Note the `"fabric":true` and `"concurrentRoot":true` properties. | ||
|
|
||
| Make sure your code passes TypeScript and ESLint. Run the following to verify: | ||
|
|
||
| ```sh | ||
| yarn typecheck | ||
| yarn lint | ||
| ``` | ||
|
|
||
| To fix formatting errors, run the following: | ||
|
|
||
| ```sh | ||
| yarn lint --fix | ||
| ``` | ||
|
|
||
| Remember to add tests for your change if possible. Run the unit tests by: | ||
|
|
||
| ```sh | ||
| yarn test | ||
| ``` | ||
|
|
||
| ### Commit message convention | ||
|
|
||
| We follow the [conventional commits specification](https://www.conventionalcommits.org/en) for our commit messages: | ||
|
|
||
| - `fix`: bug fixes, e.g. fix crash due to deprecated method. | ||
| - `feat`: new features, e.g. add new method to the module. | ||
| - `refactor`: code refactor, e.g. migrate from class components to hooks. | ||
| - `docs`: changes into documentation, e.g. add usage example for the module.. | ||
descorp marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - `test`: adding or updating tests, e.g. add integration tests using detox. | ||
| - `chore`: tooling changes, e.g. change CI config. | ||
|
|
||
| Our pre-commit hooks verify that your commit message matches this format when committing. | ||
|
|
||
| ### Linting and tests | ||
|
|
||
| [ESLint](https://eslint.org/), [Prettier](https://prettier.io/), [TypeScript](https://www.typescriptlang.org/) | ||
|
|
||
| We use [TypeScript](https://www.typescriptlang.org/) for type checking, [ESLint](https://eslint.org/) with [Prettier](https://prettier.io/) for linting and formatting the code, and [Jest](https://jestjs.io/) for testing. | ||
|
|
||
| Our pre-commit hooks verify that the linter and tests pass when committing. | ||
|
|
||
| ### Publishing to npm | ||
|
|
||
| We use [release-it](https://github.com/release-it/release-it) to make it easier to publish new versions. It handles common tasks like bumping version based on semver, creating tags and releases etc. | ||
|
|
||
| To publish new versions, run the following: | ||
|
|
||
| ```sh | ||
| yarn release | ||
| ``` | ||
|
|
||
| ### Scripts | ||
|
|
||
| The `package.json` file contains various scripts for common tasks: | ||
|
|
||
| - `yarn`: setup project by installing dependencies. | ||
| - `yarn typecheck`: type-check files with TypeScript. | ||
| - `yarn lint`: lint files with ESLint. | ||
| - `yarn test`: run unit tests with Jest. | ||
| - `yarn example start`: start the Metro server for the example app. | ||
| - `yarn example android`: run the example app on Android. | ||
| - `yarn example ios`: run the example app on iOS. | ||
|
|
||
| ### Sending a pull request | ||
|
|
||
| > **Working on your first pull request?** You can learn how from this _free_ series: [How to Contribute to an Open Source Project on GitHub](https://app.egghead.io/playlists/how-to-contribute-to-an-open-source-project-on-github). | ||
| When you're sending a pull request: | ||
|
|
||
| - Prefer small pull requests focused on one change. | ||
| - Verify that linters and tests are passing. | ||
| - Review the documentation to make sure it looks good. | ||
| - Follow the pull request template when opening a pull request. | ||
| - For pull requests that change the API or implementation, discuss with maintainers first by opening an issue. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| source 'https://rubygems.org' | ||
|
|
||
| # You may use http://rbenv.org/ or https://rvm.io/ to install and use this version | ||
| ruby ">= 2.6.10" | ||
|
|
||
| # Exclude problematic versions of cocoapods and activesupport that causes build failures. | ||
| gem 'cocoapods', '>= 1.13', '!= 1.15.0', '!= 1.15.1' | ||
| gem 'activesupport', '>= 6.1.7.5', '!= 7.1.0' | ||
| gem 'xcodeproj', '< 1.26.0' | ||
| gem 'concurrent-ruby', '< 1.3.4' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| ComAdyenreactnativesdkModule_kotlinVersion=1.9.24 | ||
| ComAdyenreactnativesdkModule_minSdkVersion=21 | ||
| ComAdyenreactnativesdkModule_targetSdkVersion=34 | ||
| ComAdyenreactnativesdkModule_compileSdkVersion=34 | ||
| ReactNative_kotlinVersion=2.0.21 | ||
| ReactNative_minSdkVersion=24 | ||
Robert-SD marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ReactNative_targetSdkVersion=34 | ||
| ReactNative_compileSdkVersion=35 | ||
| ReactNative_ndkVersion=27.1.12297006 | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.