Update callBackUrl on Voice to match the casing expected by the API#50
Open
MillerAdulu wants to merge 1 commit intoAfricasTalkingLtd:masterfrom
Open
Update callBackUrl on Voice to match the casing expected by the API#50MillerAdulu wants to merge 1 commit intoAfricasTalkingLtd:masterfrom
callBackUrl on Voice to match the casing expected by the API#50MillerAdulu wants to merge 1 commit intoAfricasTalkingLtd:masterfrom
Conversation
SamuelMwangiW
approved these changes
Mar 7, 2025
Contributor
SamuelMwangiW
left a comment
SamuelMwangiW
left a comment
There was a problem hiding this comment.
LGTM. I wish these were covered by tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bug with this SDK where the
callbackUrlfor voice commands isn't being properly set, so when passed in correctly, the SDK doesn't pick it up so a user ends up in a loop requesting for Digits.