Skip to content

Update callBackUrl on Voice to match the casing expected by the API #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MillerAdulu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update callBackUrl on Voice to match the casing expected by the API #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/Voice.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,9 @@ protected function buildGetDigits($options) {
$finishOnKey = $options['finishOnKey'];

// Get callbackURL
if (isset($options['callBackUrl'])) {
$callBackUrl = $options['callBackUrl'];
if (!$this->isValidURL($callBackUrl)) {
if (isset($options['callbackUrl'])) {
$callbackUrl = $options['callbackUrl'];
if (!$this->isValidURL($callbackUrl)) {
return $this->error('Please set a valid callback URL');
}
}
Expand All @@ -252,8 +252,8 @@ protected function buildGetDigits($options) {
if (!empty($numDigits)) {
$getDigitsString .= ' numDigits="'. $numDigits .'"';
}
if (!empty($callBackUrl)) {
$getDigitsString .= ' callBackUrl="'. $callBackUrl .'"';
if (!empty($callbackUrl)) {
$getDigitsString .= ' callbackUrl="'. $callbackUrl .'"';
}
$getDigitsString .= '>';

Expand Down Expand Up @@ -401,9 +401,9 @@ protected function buildRecord($options)
$playBeep ? $playBeep = "true" : $playBeep ="false";

// Get callbackURL
if (isset($options['callBackUrl'])) {
$callBackUrl = $options['callBackUrl'];
if (!$this->isValidURL($callBackUrl)) {
if (isset($options['callbackUrl'])) {
$callbackUrl = $options['callbackUrl'];
if (!$this->isValidURL($callbackUrl)) {
return $this->error('Please set a valid callback URL');
}
}
Expand All @@ -425,8 +425,8 @@ protected function buildRecord($options)
if (!empty($playBeep)) {
$playBeep .= ' playBeep="'. $playBeep .'"';
}
if (!empty($callBackUrl)) {
$getDigitsString .= ' callBackUrl="'. $callBackUrl .'"';
if (!empty($callbackUrl)) {
$getDigitsString .= ' callbackUrl="'. $callbackUrl .'"';
}
$recordString .= ' />';

Expand Down