chore(vue): bump vue to newest version#911
chore(vue): bump vue to newest version#911kissmannchristoph wants to merge 3 commits intoAkryum:masterfrom
Conversation
❌ Deploy Preview for vue-virtual-scroller-demo failed.
|
Summary of ChangesHello @kissmannchristoph, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the Vue.js dependency within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request upgrades the Vue.js dependency for the vue-virtual-scroller package. My main feedback is about an inconsistency this introduces: the demo application is not updated to use the same Vue version. This can lead to a situation where the library is developed against one version of Vue, but the demo, which is a key part of testing and validation, uses another. This could hide compatibility issues. I've left a specific comment with a suggestion on how to resolve this. Otherwise, the dependency updates look correct.
| "rollup-plugin-terser": "^5.3.0", | ||
| "rollup-plugin-vue": "^6.0.0", | ||
| "vue": "^3.2.41" | ||
| "vue": "^3.5.27" |
There was a problem hiding this comment.
While you've updated the vue dev dependency here to ^3.5.27, the vue dependency in packages/demo/package.json is still ^3.2.41. In a monorepo, it's crucial to keep core dependencies like Vue consistent across packages to avoid compatibility issues. The demo app should be tested against the same Vue version the library is developed with.
Please consider updating the vue dependency in packages/demo/package.json as well. You can likely achieve this by running pnpm up -r vue at the root of the repository.
Additionally, it would be beneficial to review the peerDependencies for vue in this package. Since you are now developing against 3.5.27, you might want to adjust the peerDependencies (currently ^3.2.0) to better inform consumers about compatibility, for example, by changing it to >=3.2.0.
|
Gemini, the build is failing because pnpm needs a higher node version. |
I need that package in my project, but its incompatible with the newest vue 3 version.