Skip to content

chore(vue): bump vue to newest version#911

Closed
kissmannchristoph wants to merge 3 commits intoAkryum:masterfrom
kissmannchristoph:master
Closed

chore(vue): bump vue to newest version#911
kissmannchristoph wants to merge 3 commits intoAkryum:masterfrom
kissmannchristoph:master

Conversation

@kissmannchristoph
Copy link

I need that package in my project, but its incompatible with the newest vue 3 version.

@netlify
Copy link

netlify bot commented Jan 22, 2026

Deploy Preview for vue-virtual-scroller-demo failed.

Name Link
🔨 Latest commit a9179bf
🔍 Latest deploy log https://app.netlify.com/projects/vue-virtual-scroller-demo/deploys/6971e8852b85df000894b69d

@gemini-code-assist
Copy link

Summary of Changes

Hello @kissmannchristoph, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the Vue.js dependency within the vue-virtual-scroller package to version 3.5.27. This update is crucial for resolving compatibility issues with another package in the project, as indicated by the author. The changes primarily involve updating the package.json to specify the new Vue version and subsequently regenerating the pnpm-lock.yaml to ensure all dependent packages are aligned with the updated Vue ecosystem.

Highlights

  • Vue Dependency Upgrade: The vue dependency in packages/vue-virtual-scroller/package.json has been upgraded from version ^3.2.41 to ^3.5.27.
  • Lock File Updates: The pnpm-lock.yaml file has been extensively updated to reflect the new Vue version and its transitive dependencies. This includes various @vue/* packages (e.g., @vue/compiler-sfc, @vue/runtime-dom), as well as other related libraries such as @babel/*, csstype, entities, magic-string, and postcss.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kissmannchristoph kissmannchristoph changed the title upgrade vue chore(vue): bump vue to newest version Jan 22, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the Vue.js dependency for the vue-virtual-scroller package. My main feedback is about an inconsistency this introduces: the demo application is not updated to use the same Vue version. This can lead to a situation where the library is developed against one version of Vue, but the demo, which is a key part of testing and validation, uses another. This could hide compatibility issues. I've left a specific comment with a suggestion on how to resolve this. Otherwise, the dependency updates look correct.

"rollup-plugin-terser": "^5.3.0",
"rollup-plugin-vue": "^6.0.0",
"vue": "^3.2.41"
"vue": "^3.5.27"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While you've updated the vue dev dependency here to ^3.5.27, the vue dependency in packages/demo/package.json is still ^3.2.41. In a monorepo, it's crucial to keep core dependencies like Vue consistent across packages to avoid compatibility issues. The demo app should be tested against the same Vue version the library is developed with.

Please consider updating the vue dependency in packages/demo/package.json as well. You can likely achieve this by running pnpm up -r vue at the root of the repository.

Additionally, it would be beneficial to review the peerDependencies for vue in this package. Since you are now developing against 3.5.27, you might want to adjust the peerDependencies (currently ^3.2.0) to better inform consumers about compatibility, for example, by changing it to >=3.2.0.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm up -r vue done

@kissmannchristoph
Copy link
Author

Gemini, the build is failing because pnpm needs a higher node version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments