Skip to content

chore(vue): bump vue to newest version #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kissmannchristoph wants to merge 3 commits into from
+162 −57
Closed

chore(vue): bump vue to newest version #911

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
610fcb0
upgrade vue
Jan 22, 2026
3d31209
upgrade vue in demo
Jan 22, 2026
a9179bf
run pnpm up -r vue
Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vue-virtual-scroller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"rollup-plugin-css-porter": "^1.0.2",
"rollup-plugin-terser": "^5.3.0",
"rollup-plugin-vue": "^6.0.0",
"vue": "^3.2.41"
"vue": "^3.5.27"
Copy link

@gemini-code-assist gemini-code-assist bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While you've updated the vue dev dependency here to ^3.5.27, the vue dependency in packages/demo/package.json is still ^3.2.41. In a monorepo, it's crucial to keep core dependencies like Vue consistent across packages to avoid compatibility issues. The demo app should be tested against the same Vue version the library is developed with.

Please consider updating the vue dependency in packages/demo/package.json as well. You can likely achieve this by running pnpm up -r vue at the root of the repository.

Additionally, it would be beneficial to review the peerDependencies for vue in this package. Since you are now developing against 3.5.27, you might want to adjust the peerDependencies (currently ^3.2.0) to better inform consumers about compatibility, for example, by changing it to >=3.2.0.

Copy link
Author

@kissmannchristoph kissmannchristoph Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm up -r vue done

},
"browserslist": [
"> 1%",
Expand Down
Loading
Loading