Skip to content

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 15, 2025

What is this pull request for?

The resource info for attachments has a auto collapsing preview. Since filenames can be very long if they are hosted on remote blob storages we need to constrain the width.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen requested a review from a team as a code owner December 15, 2025 15:34
@tvdeyen tvdeyen added bug backport-to-8.0-stable Needs to be backported to 8.0-stable labels Dec 15, 2025
@tvdeyen tvdeyen force-pushed the fix-resource-info-width branch from f71daee to 770feb1 Compare December 15, 2025 16:48
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.19%. Comparing base (aad0e7c) to head (a8272d6).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3516   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files         287      287           
  Lines        7559     7559           
=======================================
  Hits         7347     7347           
  Misses        212      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen force-pushed the fix-resource-info-width branch from 770feb1 to f5375f3 Compare December 17, 2025 11:44
The resource info for attachments has a auto collapsing
preview. Since filenames can be very long if they are
hosted on remote blob storages we need to constrain
the width.

Signed-off-by: Thomas von Deyen <[email protected]>
@tvdeyen tvdeyen force-pushed the fix-resource-info-width branch from f5375f3 to 63056b7 Compare December 17, 2025 11:44
Long sentences do not fit well in the picture sidebar
on small screens. And this is more grammatically correct
anyway.

Signed-off-by: Thomas von Deyen <[email protected]>
@tvdeyen tvdeyen merged commit 3160be9 into main Dec 17, 2025
18 checks passed
@tvdeyen tvdeyen deleted the fix-resource-info-width branch December 17, 2025 14:46
@alchemycms-bot
Copy link

💔 All backports failed

Status Branch Result
8.0-stable Backport failed because of merge conflicts

You might need to backport the following PRs to 8.0-stable:
- Remove dialog sitemap css code
- Fix sitemap highlight color in dark mode
- Make create element dialog wider (#3445)
- Fix element icon hover for elements with warning (#3444)
- Fix select2 close icon visibility (#3443)

Manual backport

To create the backport manually run:

backport --pr 3516

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@tvdeyen
Copy link
Member Author

tvdeyen commented Dec 17, 2025

💚 All backports created successfully

Status Branch Result
8.0-stable

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-8.0-stable Needs to be backported to 8.0-stable bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants