[8.0-stable] fix(resource-info): Fix layout for long filenames #3523
+70
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resource info for attachments has a auto collapsing preview. Since filenames can be very long if they are hosted on remote blob storages we need to constrain the width. Signed-off-by: Thomas von Deyen <[email protected]> (cherry picked from commit 63056b7) # Conflicts: # app/assets/builds/alchemy/admin.css # app/assets/builds/alchemy/dark-theme.css # app/assets/builds/alchemy/light-theme.css # app/assets/builds/alchemy/theme.css
Long sentences do not fit well in the picture sidebar on small screens. And this is more grammatically correct anyway. Signed-off-by: Thomas von Deyen <[email protected]> (cherry picked from commit a8272d6)
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.0-stable #3523 +/- ##
===========================================
Coverage 97.18% 97.18%
===========================================
Files 287 287
Lines 7521 7521
===========================================
Hits 7309 7309
Misses 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.0-stable:Questions ?
Please refer to the Backport tool documentation