Replace HTTP status code symbols with numeric codes #3555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rack 3.1 renamed :unprocessable_entity to :unprocessable_content, which causes deprecation warnings. Since AlchemyCMS supports Rails 7.1+ (which can use Rack 2.x, 3.0, or 3.1+), using numeric codes ensures compatibility across all Rack versions without warnings. For consistency, all HTTP status code symbols have been replaced with their numeric equivalents: - :unprocessable_entity → 422 - :created → 201 - :accepted → 202 - :unauthorized → 401 - :moved_permanently → 301 - :ok → 200
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3555 +/- ##
=======================================
Coverage 97.25% 97.25%
=======================================
Files 291 291
Lines 7682 7682
=======================================
Hits 7471 7471
Misses 211 211 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mamhoff
approved these changes
Jan 7, 2026
Contributor
mamhoff
left a comment
mamhoff
left a comment
There was a problem hiding this comment.
For readability I do prefer the symbols, but I'm not dying on that hill.
Member
Author
Yea, but needing to remember the symbol instead of the well known numbers? Unnecessary complexity imo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Replace all HTTP status code symbols with numeric codes to avoid Rack 3.1+ deprecation warnings.
Rack 3.1 renamed
:unprocessable_entityto:unprocessable_content, which causes deprecation warnings. Since AlchemyCMS supports Rails 7.1+ (which can use Rack 2.x, 3.0, or 3.1+), using numeric codes ensures compatibility across all Rack versions without warnings.For consistency, all status code symbols have been replaced:
:unprocessable_entity→ 422:created→ 201:accepted→ 202:unauthorized→ 401:moved_permanently→ 301:ok→ 200Checklist