Fix size_only arg in download_s3_path not being passed fully#28
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
=======================================
Coverage 88.74% 88.74%
=======================================
Files 37 37
Lines 3385 3385
Branches 491 491
=======================================
Hits 3004 3004
Misses 285 285
Partials 96 96
🚀 New features to boost your workflow:
|
rpmcginty
approved these changes
Apr 2, 2025
njmei
force-pushed
the
fix-data-sync-issue
branch
from
c105f59 to
0521b1d
Compare
njmei
force-pushed
the
fix-data-sync-issue
branch
from
0521b1d to
42a5730
Compare
njmei
changed the title
size_only missing arg, causing should_sync unexpected behavior size_only arg in download_s3_path not being passed fully
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.