Skip to content

Conversation

@rpmcginty
Copy link
Collaborator

@rpmcginty rpmcginty commented Oct 14, 2025

What's in this Change?

upgrading the mypy version and updating the configs to support site packages

@rpmcginty rpmcginty requested a review from njmei October 14, 2025 18:36
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 69.07216% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.02%. Comparing base (27de389) to head (6c5660b).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/aibs_informatics_aws_utils/sns.py 34.78% 6 Missing and 9 partials ⚠️
src/aibs_informatics_aws_utils/batch.py 61.90% 3 Missing and 5 partials ⚠️
src/aibs_informatics_aws_utils/ec2.py 85.00% 1 Missing and 2 partials ⚠️
src/aibs_informatics_aws_utils/efs/core.py 0.00% 1 Missing and 1 partial ⚠️
src/aibs_informatics_aws_utils/athena.py 85.71% 0 Missing and 1 partial ⚠️
src/aibs_informatics_aws_utils/fsx.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   88.57%   88.02%   -0.55%     
==========================================
  Files          37       37              
  Lines        3386     3432      +46     
  Branches      491      507      +16     
==========================================
+ Hits         2999     3021      +22     
- Misses        290      298       +8     
- Partials       97      113      +16     
Files with missing lines Coverage Δ
src/aibs_informatics_aws_utils/core.py 95.52% <100.00%> (ø)
...aibs_informatics_aws_utils/data_sync/operations.py 90.58% <100.00%> (ø)
.../aibs_informatics_aws_utils/dynamodb/conditions.py 99.23% <100.00%> (ø)
...c/aibs_informatics_aws_utils/dynamodb/functions.py 81.66% <100.00%> (+0.20%) ⬆️
src/aibs_informatics_aws_utils/dynamodb/table.py 94.11% <100.00%> (ø)
src/aibs_informatics_aws_utils/ecr/core.py 96.18% <ø> (ø)
...aibs_informatics_aws_utils/ecr/image_replicator.py 55.72% <ø> (ø)
src/aibs_informatics_aws_utils/ecs.py 100.00% <100.00%> (ø)
src/aibs_informatics_aws_utils/efs/mount_point.py 86.17% <100.00%> (+0.06%) ⬆️
src/aibs_informatics_aws_utils/efs/paths.py 97.67% <100.00%> (ø)
... and 9 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@njmei njmei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, but overall looks reasonable

@rpmcginty rpmcginty force-pushed the feature/upgrade-mypy-configs branch from ab8f716 to ec41883 Compare October 14, 2025 20:29
@rpmcginty rpmcginty force-pushed the feature/upgrade-mypy-configs branch from ec41883 to 6c5660b Compare October 14, 2025 20:30
@rpmcginty rpmcginty merged commit 5216328 into main Oct 14, 2025
8 checks passed
@rpmcginty rpmcginty deleted the feature/upgrade-mypy-configs branch October 14, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants