Update packaging to pyproject.toml #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-b
force-pushed
the
update-packaging
branch
2 times, most recently
from
1958163 to
50b403e
Compare
t-b
changed the title
5 tasks
t-b
force-pushed
the
update-packaging
branch
3 times, most recently
from
3fb547b to
2cac8a3
Compare
t-b
force-pushed
the
update-packaging
branch
from
2cac8a3 to
b0f4d9a
Compare
Created with hatch new --init.
The new way of packaging in python is based on pyproject.toml. This allows us to have only one file defining the package properties instead of three. We also switch to hatch instead of setuptools. And the version number is now gathered from git instead of being hardcoded in ipfx/version.txt. The new source package (sdist) has the following differences: - We don't ship the tests folder anymore. It is not usable without datafiles anyway and including them would require ~250MB of disc space. - `ipfx/version.txt` is gone as the version is now gathered from git with the build-time created `ipfx/_version.py` - No more IPFX.egg-info/MANIFEST.in/setup.cfg/setup.py but only pyproject.toml - Added missing files in docs The wheel is now different in the following regard: - It is not an universal wheel anymore as Python 2 support is already long gone - No more `*dist-info` folder as we are now packaging with hatch, the files LICENSE and AUTHORS.rst are therefore manually included - Same comment regarding `ipfx/version.txt` as in the sdist The flake8 configuration can not be included in pyproject.toml, see PyCQA/flake8#234. It will also be replaced by another linter in a future commit.
And also standardize on dashes like we do for test.
We don't use a dev branch anymore and also version.txt is gone. Mention also the switch from setuptools to hatch.
Only this creates ipfx/_version.py.
t-b
force-pushed
the
update-packaging
branch
from
b0f4d9a to
7ce45c4
Compare
Collaborator
Author
|
@gouwens And the next one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #574