fix: Removed assumption of annotation SVG's existence [DC-498]#50
Merged
fix: Removed assumption of annotation SVG's existence [DC-498]#50
Conversation
lanesawyer
reviewed
Jan 30, 2025
Collaborator
lanesawyer
left a comment
There was a problem hiding this comment.
This fixes the issue, but I think the image check logic should live in buildCompositor instead so that we don't have two ctx.putImageData(image, 0, 0) lines floating around.
Not completely opposed to shipping it as-is though. The logic here isn't too complex. Just nervous that it'll grow as we polish up the viewer and then we'll be duplicating more and more instead of having a single function that does the proper drawings.
Contributor
Author
|
I've made updates in the |
lanesawyer
approved these changes
Jan 31, 2025
lanesawyer
approved these changes
Jan 31, 2025
Collaborator
lanesawyer
left a comment
There was a problem hiding this comment.
Looks good after merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Removed assumption of annotation SVG's existence [DC-498]
What
DZI images without associated annotation SVGs were failing to render. Since it is valid for DZI images to not have associated annotation SVGs, removed this assumption to prevent issues during rendering.
How
compose(which was always created viabuildCompositorand assumed an SVG's existence) with a variablerenderthat falls back toputImageDatawhen no SVG is found.PR Checklist
main?