Implement OperantLogic.stop_duration as a distribution instead of scalar value
#450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-f-cruz
changed the title
OperantLogic.stop_duration as a distribution instead of scalar value
bruno-f-cruz
added a commit
that referenced
this pull request
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be fully backwards compatible due to the custom validator implemented in AllenNeuralDynamics/Aind.Behavior.Services#174.
As a result, any numeric values (e.g. the previously typed
float) that are passed to the annotated typedistributions.Distributionwill be automatically coerced to aScalartype.While it is technically a breaking change for analysis code downstream, the "true" stop duration should be extracted from real data anyway,.
In addition, the implementation of the
StopDurationOffsetwas cleaned up by moving the calculation to the point of reward computation instead of site creation. This is in line with other modifiers that are applied on top of the computation and NOT instantiation.Closes #449