Skip to content

Conversation

@RichardSWheatley
Copy link
Member

add new board
add confs and overlays
update some kxr items

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the Apollo4 Blue Plus KBR EVB board, including board definition files, test configurations, sample overlays, and updates to the west.yml Ambiq HAL revision.

Key changes:

  • Board definition files for new apollo4p_blue_kbr_evb board
  • Test overlays and configurations for various drivers (RTC, PWM, GPIO, counter, ADC)
  • Sample overlays for LED and counter applications
  • Updated west.yml revision for Ambiq HAL module

Reviewed Changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
west.yml Updates Ambiq HAL revision to newer version
boards/ambiq/apollo4p_blue_kbr_evb/* Complete board definition including DTS, pinctrl, Kconfig, and documentation
tests/drivers//boards/apollo4p_blue_kbr_evb. Test configurations and overlays for the new board
samples/*/boards/apollo4p_blue_kbr_evb.overlay Sample application overlays for the new board
boards/ambiq/apollo4p_blue_kxr_evb/apollo4p_blue_kxr_evb-pinctrl.dtsi Updates existing KXR board to include connector definitions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Sep 18, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
ambiqhal_ambiq AmbiqMicro/ambiqhal_ambiq@016bf09 (apollo510-dev) AmbiqMicro/ambiqhal_ambiq@9647b40 (apollo4-build-updates) AmbiqMicro/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 26 out of 27 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

add new board
add confs and overlays
update some kxr items

Signed-off-by: Richard Wheatley <[email protected]>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 26 out of 27 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +60 to +63
#if APOLLO4P_BLUE_KBR_EVB
#undef UART3RX_P3
#define UART3RX_P3 APOLLO4_PINMUX(3, 4)
#endif
Copy link

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using preprocessor conditionals based on board-specific macros in a shared header file creates board-specific dependencies. Consider using device tree overlays or board-specific pinctrl files instead of conditional compilation in shared headers.

Suggested change
#if APOLLO4P_BLUE_KBR_EVB
#undef UART3RX_P3
#define UART3RX_P3 APOLLO4_PINMUX(3, 4)
#endif

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants