Skip to content

fix: some launch review issues#7379

Merged
LucasXu0 merged 6 commits intoAppFlowy-IO:mainfrom
asjqkkkk:fix/launch_review
Feb 17, 2025
Merged

fix: some launch review issues#7379
LucasXu0 merged 6 commits intoAppFlowy-IO:mainfrom
asjqkkkk:fix/launch_review

Conversation

@asjqkkkk
Copy link
Collaborator

@asjqkkkk asjqkkkk commented Feb 13, 2025

Fix the issue listed below:

  • the slash menu position is incorrect
  • The title doesn’t display properly
  • the arrow in the menu is not visible on dark mode
  • mention page icon is cropped. See: paper clip icon
  • table and date or reminder should have no second leven menu
  • presses backspace to return first layer
  • slash menu reorganization
  • add change button for icon uploader
  • enable dragging a svg file to upload as icon

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@github-actions
Copy link

github-actions bot commented Feb 13, 2025

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 290 warning contribute (via Fink 🐦)

@asjqkkkk asjqkkkk force-pushed the fix/launch_review branch 4 times, most recently from b884f16 to ba3bbe4 Compare February 14, 2025 02:46
@asjqkkkk asjqkkkk force-pushed the fix/launch_review branch 3 times, most recently from 84eb286 to 5003897 Compare February 15, 2025 12:00
@asjqkkkk asjqkkkk force-pushed the fix/launch_review branch 2 times, most recently from 0cab353 to b6d3e96 Compare February 17, 2025 07:28
@LucasXu0 LucasXu0 merged commit c0aa0e0 into AppFlowy-IO:main Feb 17, 2025
18 checks passed
@asjqkkkk asjqkkkk deleted the fix/launch_review branch March 26, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants