Conversation
Contributor
Reviewer's GuideThis PR refactors the link embed block to make the entire preview clickable by consolidating gesture handling into a single MouseRegion/GestureDetector wrapper, and it removes the bold font weight from heading mention nodes in the notification center. Sequence Diagram: Unified Link Embed Click InteractionsequenceDiagram
actor User
participant LEBC as "LinkEmbedBlockComponent"
participant GD as "GestureDetector (Unified)"
participant AFLU as "afLaunchUrlString()"
User->>LEBC: Taps on any part of embed link
activate LEBC
LEBC->>GD: Tap event forwarded
activate GD
GD-->>LEBC: Executes onTap (handler within LEBC)
deactivate GD
LEBC->>AFLU: Calls afLaunchUrlString(url)
deactivate LEBC
Updated Class Diagram: NotificationDocumentContent (Styling Adjustment)classDiagram
class NotificationDocumentContent {
+build(BuildContext context) Widget
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @asjqkkkk - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
.../lib/plugins/document/presentation/editor_plugins/link_embed/link_embed_block_component.dart
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Preview
PR Checklist
Summary by Sourcery
Fix click behavior of link embed component and remove bold font weight from notification center heading mentions
Bug Fixes: