-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
fix: some LR issues #8034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: some LR issues #8034
Conversation
Reviewer's GuideThis PR refactors the link embed block to make the entire preview clickable by consolidating gesture handling into a single MouseRegion/GestureDetector wrapper, and it removes the bold font weight from heading mention nodes in the notification center. Sequence Diagram: Unified Link Embed Click InteractionsequenceDiagram
actor User
participant LEBC as "LinkEmbedBlockComponent"
participant GD as "GestureDetector (Unified)"
participant AFLU as "afLaunchUrlString()"
User->>LEBC: Taps on any part of embed link
activate LEBC
LEBC->>GD: Tap event forwarded
activate GD
GD-->>LEBC: Executes onTap (handler within LEBC)
deactivate GD
LEBC->>AFLU: Calls afLaunchUrlString(url)
deactivate LEBC
Updated Class Diagram: NotificationDocumentContent (Styling Adjustment)classDiagram
class NotificationDocumentContent {
+build(BuildContext context) Widget
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @asjqkkkk - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Feature Preview
PR Checklist
Summary by Sourcery
Fix click behavior of link embed component and remove bold font weight from notification center heading mentions
Bug Fixes: