Skip to content

fix: some LR issues #8034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LucasXu0 merged 2 commits into from
Jun 9, 2025
Merged

fix: some LR issues #8034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15b83e4
fix: allow the whole embed link clickable
asjqkkkk Jun 6, 2025
6aa3182
fix: remove bold style of head mention node in notification center
asjqkkkk Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions frontend/appflowy_flutter/lib/mobile/presentation/notifications/widgets/shared.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,10 +341,7 @@ class NotificationDocumentContent extends StatelessWidget {
.orDefault(
context.read<AppearanceSettingsCubit>().state.font,
);
return styleCustomizer.baseTextStyle(
fontFamily,
fontWeight: FontWeight.w600,
);
return styleCustomizer.baseTextStyle(fontFamily);
},
);
blockBuilders[HeadingBlockKeys.type] = newHeadingBuilder;
Expand Down
46 changes: 19 additions & 27 deletions ...b/plugins/document/presentation/editor_plugins/link_embed/link_embed_block_component.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,33 +189,25 @@ class LinkEmbedBlockComponentState
Widget buildContent(BuildContext context) {
final theme = AppFlowyTheme.of(context), textScheme = theme.textColorScheme;
final hasSiteName = linkInfo.siteName?.isNotEmpty ?? false;
return Column(
crossAxisAlignment: CrossAxisAlignment.start,
children: [
Expanded(
child: GestureDetector(
behavior: HitTestBehavior.opaque,
onTap: !UniversalPlatform.isMobile
? null
: () =>
afLaunchUrlString(url, addingHttpSchemeWhenFailed: true),
child: ClipRRect(
borderRadius:
const BorderRadius.vertical(top: Radius.circular(16)),
child: FlowyNetworkImage(
url: linkInfo.imageUrl ?? '',
width: MediaQuery.of(context).size.width,
return MouseRegion(
cursor: SystemMouseCursors.click,
child: GestureDetector(
behavior: HitTestBehavior.opaque,
onTap: () => afLaunchUrlString(url, addingHttpSchemeWhenFailed: true),
child: Column(
crossAxisAlignment: CrossAxisAlignment.start,
children: [
Expanded(
child: ClipRRect(
borderRadius:
const BorderRadius.vertical(top: Radius.circular(16)),
child: FlowyNetworkImage(
url: linkInfo.imageUrl ?? '',
width: MediaQuery.of(context).size.width,
),
),
),
),
),
MouseRegion(
cursor: SystemMouseCursors.click,
child: GestureDetector(
behavior: HitTestBehavior.opaque,
onTap: () =>
afLaunchUrlString(url, addingHttpSchemeWhenFailed: true),
child: Container(
Container(
height: 64,
padding: const EdgeInsets.symmetric(vertical: 12, horizontal: 20),
child: Row(
Expand Down Expand Up @@ -256,9 +248,9 @@ class LinkEmbedBlockComponentState
],
),
),
),
],
),
],
),
);
}

Expand Down
Loading