runtime: add trivial mmap failure check #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for testing: |
|
Build for testing: |
TheAssassin
approved these changes
Jan 1, 2025
Member
TheAssassin
left a comment
TheAssassin
left a comment
There was a problem hiding this comment.
Looks good, but in theory, you'd have to add additional checks for open, close etc.
Contributor
Author
i could if you wish, but i thought the mmap was a bit more hazardous since it will likely segfault on failure rather than just give an error when it fails due to the subsequent array access into the pointer. |
Member
|
Sorry for the merge delay, I forgot about this PR. |
Contributor
Author
|
i've rebased onto HEAD of main. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.