Skip to content

runtime: add trivial mmap failure check #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheAssassin merged 1 commit into from
May 30, 2025
Merged

runtime: add trivial mmap failure check #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/runtime/runtime.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,11 @@ bool appimage_get_elf_section_offset_and_length(const char* fname, const char* s
data = mmap(NULL, map_size, PROT_READ, MAP_SHARED, fd, 0);
close(fd);

if (data == MAP_FAILED) {
fprintf(stderr, "Failed to mmap file %s: %s\n", fname, strerror(errno));
return false;
}

// this trick works as both 32 and 64 bit ELF files start with the e_ident[EI_NINDENT] section
unsigned char class = data[EI_CLASS];

Expand Down