Potential fix for code scanning alert no. 7: Shell command built from environment values #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… environment values Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/ArcticFoxPro/QQVersionListTool-WeChatMiniProgram/security/code-scanning/7
To fix the problem, we should avoid constructing the shell command as a single string and instead use
execFileSyncwith an array of arguments. This approach ensures that each argument is passed to the command without being interpreted by the shell, thus preventing command injection vulnerabilities.We will modify the
runCommandfunction to useexecFileSyncand update thebuildLicensesfunction to pass the command and arguments separately.Suggested fixes powered by Copilot Autofix. Review carefully before merging.