Skip to content

Potential fix for code scanning alert no. 7: Shell command built from environment values #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArcticFoxPro merged 1 commit into from
Feb 2, 2025
Merged

Potential fix for code scanning alert no. 7: Shell command built from environment values #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions source/OSSLicensesJSONBuild.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@
* 每次小程序发布前均需手动执行 `node OSSLicensesJSONBuild.js`
*/

const { execSync } = require('child_process');
const { execFileSync } = require('child_process');
const fs = require('fs');
const path = require('path');

function runCommand(command) {
function runCommand(command, args) {
try {
return execSync(command, { encoding: 'utf8' });
return execFileSync(command, args, { encoding: 'utf8' });
} catch (error) {
console.error(`命令执行失败: ${command}`);
console.error(`命令执行失败: ${command} ${args.join(' ')}`);
process.exit(1);
}
}
Expand All @@ -44,8 +44,9 @@ function runCommand(command) {
function buildLicenses(outputFile, customPath, startPath = '') {
const jsonFile = path.join(__dirname, `pages/utils/${outputFile}.json`);
const jsFile = path.join(__dirname, `pages/utils/${outputFile}.js`);
const command = `license-checker-rseidelsohn ${startPath} --customPath ${customPath} --json`;
const output = runCommand(command);
const command = 'license-checker-rseidelsohn';
const args = [startPath, '--customPath', customPath, '--json'];
const output = runCommand(command, args);
fs.writeFileSync(jsonFile, output, 'utf8');
const jsonData = JSON.parse(output);
const jsContent = `module.exports = ${JSON.stringify(jsonData, null, 2)};`;
Expand Down