Add # flake8: noqa directive to all failing files

.github/workflows/python-cleanliness.yml

@@ -11,15 +11,17 @@ jobs:
     runs-on: ubuntu-22.04
 
     steps:
-      # git checkout the PR
       - uses: actions/checkout@v5
         with:
           submodules: 'recursive'
 
+      # Run flake8 but exclude git submodules and third-party libraries
+      - run: pipx run flake8 --show-source --exclude=MAVProxy/modules/mavproxy_cesium
+
       - name: Install dependencies
         run: |
-          python -m pip install -U flake8
+          python -m pip install --upgrade flake8
 
       - name: Check Python with Flake8
         run: |
-            scripts/run_flake8.py MAVProxy
+          scripts/run_flake8.py MAVProxy

MAVProxy/modules/lib/ANUGA/geo_reference.py

@@ -4,6 +4,7 @@
 
 """
 
+# flake8: noqa
 
 #FIXME: Ensure that all attributes of a georef are treated everywhere
 #and unit test

MAVProxy/modules/lib/ANUGA/lat_long_UTM_conversion.py

@@ -5,6 +5,8 @@
 # see http://www.pygps.org
 #
 
+# flake8: noqa
+
 from math import pi, sin, cos, tan, sqrt
 
 #LatLong- UTM conversion..h

MAVProxy/modules/lib/ANUGA/redfearn.py

@@ -12,6 +12,8 @@
 http://www.icsm.gov.au/icsm/
 
 """
+# flake8: noqa
+
 from MAVProxy.modules.lib.ANUGA.geo_reference import Geo_reference, DEFAULT_ZONE
 
 

MAVProxy/modules/lib/LowPassFilter2p.py

@@ -1,5 +1,7 @@
 #!/usr/bin/env python3
 
+# flake8: noqa
+
 from math import *
 
 class LowPassFilter2p:

MAVProxy/modules/lib/MacOS/__init__.py

@@ -1,2 +1 @@
 # version of matplotlib backends modified to work with MacOS
-

MAVProxy/modules/lib/MacOS/backend_agg.py

@@ -19,6 +19,8 @@
   * integrate screen dpi w/ ppi and text
 
 """
+# flake8: noqa
+
 import threading
 import numpy as np
 

MAVProxy/modules/lib/MacOS/backend_wx.py

@@ -14,6 +14,8 @@
 
 """
 
+# flake8: noqa
+
 import sys
 import os
 import os.path

MAVProxy/modules/lib/MacOS/backend_wxagg.py

@@ -1,3 +1,5 @@
+# flake8: noqa
+
 import matplotlib
 from matplotlib.figure import Figure
 

MAVProxy/modules/lib/MacOS/wxversion.py

@@ -74,6 +74,8 @@
 
 """
 
+# flake8: noqa
+
 import re, sys, os, glob, fnmatch
 
 

MAVProxy/modules/lib/camera_projection.py

@@ -3,6 +3,8 @@
 class to project a camera view onto the map
 '''
 
+# flake8: noqa
+
 import json
 import math
 import time

MAVProxy/modules/lib/dumpstacks.py

@@ -1,5 +1,4 @@
-
-
+# flake8: noqa
 
 import threading, sys, traceback
 

MAVProxy/modules/lib/geodesic_grid.py

@@ -20,6 +20,8 @@
 as reference for defining the geodesic sections and implementing almost all
 functions. Those files should be consulted for implementation details.
 '''
+# flake8: noqa
+
 import math
 
 from pymavlink.rotmat import Matrix3, Vector3

MAVProxy/modules/lib/graph_ui.py

@@ -1,3 +1,5 @@
+# flake8: noqa
+
 from MAVProxy.modules.lib import grapher
 from MAVProxy.modules.lib import multiproc
 

MAVProxy/modules/lib/graphdefinition.py

@@ -2,6 +2,8 @@
 GraphDefinition class
 '''
 
+# flake8: noqa
+
 class GraphDefinition(object):
     '''a pre-defined graph'''
     def __init__(self, name, expression, description, expressions, filename):

MAVProxy/modules/lib/grapher.py

@@ -4,6 +4,8 @@
  core library for graphing in mavexplorer
 '''
 
+# flake8: noqa
+
 import ast
 import sys, struct, time, os, datetime, platform
 import math, re

MAVProxy/modules/lib/live_graph.py

@@ -8,6 +8,8 @@
   http://eli.thegreenplace.net/files/prog_code/wx_mpl_dynamic_graph.py.txt
 """
 
+# flake8: noqa
+
 import platform
 from MAVProxy.modules.lib import mp_util
 from MAVProxy.modules.lib import multiproc

MAVProxy/modules/lib/live_graph_ui.py

@@ -1,3 +1,5 @@
+# flake8: noqa
+
 from MAVProxy.modules.lib.wx_loader import wx
 from MAVProxy.modules.lib import icon
 import time

MAVProxy/modules/lib/magfit.py

@@ -4,6 +4,8 @@
 fit best estimate of magnetometer offsets, diagonals, off-diagonals, cmot and scaling using WMM target
 '''
 
+# flake8: noqa
+
 from MAVProxy.modules.lib import wx_processguard
 from MAVProxy.modules.lib.wx_loader import wx
 

MAVProxy/modules/lib/mav_fft.py

@@ -4,6 +4,8 @@
 extract ISBH and ISBD messages from AP_Logging files and produce FFT plots
 '''
 
+# flake8: noqa
+
 import numpy
 import os
 import pylab

MAVProxy/modules/lib/mp_checklist.py

@@ -5,6 +5,8 @@
   Created by Stephen Dade ([email protected])
 """
 
+# flake8: noqa
+
 import sys
 import os
 import time

MAVProxy/modules/lib/mp_elevation.py

@@ -5,6 +5,8 @@
 Created by Stephen Dade ([email protected])
 '''
 
+# flake8: noqa
+
 import os
 import sys
 import time

MAVProxy/modules/lib/mp_image.py

@@ -6,6 +6,8 @@
 June 2012
 '''
 
+# flake8: noqa
+
 import time
 from MAVProxy.modules.lib.wx_loader import wx
 import cv2

MAVProxy/modules/lib/mp_instructor.py

@@ -5,6 +5,8 @@
   André Kjellstrup @ NORCE
 """
 
+# flake8: noqa
+
 from MAVProxy.modules.lib import mp_util
 from MAVProxy.modules.lib import multiproc
 from MAVProxy.modules.lib.wx_loader import wx

MAVProxy/modules/lib/mp_menu.py

@@ -6,6 +6,8 @@
 November 2013
 '''
 
+# flake8: noqa
+
 from MAVProxy.modules.lib import mp_util
 from MAVProxy.modules.lib import multiproc
 import platform

MAVProxy/modules/lib/mp_module.py

@@ -1,3 +1,5 @@
+# flake8: noqa
+
 import time
 from pymavlink import mavutil
 import traceback

MAVProxy/modules/lib/mp_settings.py

@@ -1,6 +1,8 @@
 #!/usr/bin/env python3
 '''settings object for MAVProxy modules'''
 
+# flake8: noqa
+
 import time
 import fnmatch
 

MAVProxy/modules/lib/mp_substitute.py

@@ -2,6 +2,8 @@
 variable substitution in strings using a dictionary
 '''
 
+# flake8: noqa
+
 import sys
 
 class MAVSubstituteError(Exception):

MAVProxy/modules/lib/mp_util.py

@@ -2,6 +2,8 @@
 # -*- coding: utf-8 -*-
 '''common mavproxy utility functions'''
 
+# flake8: noqa
+
 import gzip
 import math
 import os

MAVProxy/modules/lib/mp_widgets.py

@@ -6,6 +6,8 @@
 June 2012
 '''
 
+# flake8: noqa
+
 from MAVProxy.modules.lib.wx_loader import wx
 import cv2
 import numpy as np

MAVProxy/modules/lib/msgstats.py

@@ -4,6 +4,8 @@
 show stats on messages in a log in MAVExplorer
 '''
 
+# flake8: noqa
+
 import fnmatch
 from MAVProxy.modules.lib.multiproc_util import MPDataLogChildTask
 

MAVProxy/modules/lib/multiproc.py

@@ -10,6 +10,8 @@
 make things work on MacOS
 '''
 
+# flake8: noqa
+
 class PipeQueue(object):
     '''simulate a queue using a pipe. This is used to avoid a problem with
     pipes on MacOS, while still keeping similar syntax'''

MAVProxy/modules/lib/multiproc_util.py

@@ -4,6 +4,8 @@
     custom pickle functions and class wrappers
 '''
 
+# flake8: noqa
+
 from MAVProxy.modules.lib import multiproc
 
 import copyreg

MAVProxy/modules/lib/ntrip.py

@@ -4,6 +4,8 @@
  based on client from http://github.com/jcmb/NTRIP
 """
 
+# flake8: noqa
+
 import socket
 import sys
 import datetime

MAVProxy/modules/lib/opengl.py

@@ -15,6 +15,8 @@
 '''
 Module with helpers for OpenGL rendering.
 '''
+# flake8: noqa
+
 import math
 
 from ctypes import *

MAVProxy/modules/lib/optparse_gui/__init__.py

@@ -5,6 +5,8 @@
 options/args, instead of parsing command line arguments
 '''
 
+# flake8: noqa
+
 import os
 import sys
 import re

MAVProxy/modules/lib/param_ftp.py

@@ -3,6 +3,8 @@
 decode ftp parameter protocol data
 '''
 
+# flake8: noqa
+
 import struct
 import sys
 

MAVProxy/modules/lib/param_help.py

@@ -1,3 +1,5 @@
+# flake8: noqa
+
 import time, os
 from pymavlink import mavutil, mavparm
 from MAVProxy.modules.lib import mp_util

MAVProxy/modules/lib/rline.py

@@ -2,6 +2,8 @@
 readline handling for mavproxy
 '''
 
+# flake8: noqa
+
 import sys, glob, os, platform
 import re
 

MAVProxy/modules/lib/rtcm3.py

@@ -1,6 +1,8 @@
 #!/usr/bin/env python3
 '''Decode RTCM v3 messages'''
 
+# flake8: noqa
+
 RTCMv3_PREAMBLE = 0xD3
 POLYCRC24 = 0x1864CFB
 

MAVProxy/modules/lib/srtm.py

@@ -1,5 +1,7 @@
 #!/usr/bin/env python3
 
+# flake8: noqa
+
 # Pylint: Disable name warnings
 # pylint: disable-msg=C0103
 

MAVProxy/modules/lib/textconsole.py

@@ -3,6 +3,8 @@
 """
   MAVProxy default console
 """
+# flake8: noqa
+
 import sys
 
 class SimpleConsole():

MAVProxy/modules/lib/wavefront.py

@@ -33,6 +33,8 @@
 Unsupported directives found while parsing are stored in the parser's
 ignored_directives attribute.
 '''
+# flake8: noqa
+
 import os
 try:
     import cPickle as pickle

MAVProxy/modules/lib/win_layout.py

@@ -1,5 +1,7 @@
 #!/usr/bin/env python3
 
+# flake8: noqa
+
 import os, wx, pickle
 from MAVProxy.modules.lib import mp_util
 

MAVProxy/modules/lib/wx_addlink.py

@@ -3,6 +3,8 @@
 GUI for adding new links to MAVProxy
 '''
 
+# flake8: noqa
+
 import wx
 from pymavlink import mavutil
 

MAVProxy/modules/lib/wx_loader.py

@@ -1,3 +1,5 @@
+# flake8: noqa
+
 from MAVProxy.modules.lib import wx_util
 
 if not wx_util.safe: