Add # flake8: noqa directive to all failing files

[cclauss]

Run flake8 in GitHub Actions but exclude third-party libraries
run: pipx run flake8 --exclude=MAVProxy/modules/lib

Once this has been running for a while, we can:

• delete the remaining lines in the GitHub Action
• delete scripts/run_flake8.py
• remove all instances of AP_FLAKE8_CLEAN (git grep AP_FLAKE8_CLEAN)

ArduPilot/ardupilot#30288 (comment)

% flake8 --exclude=MAVProxy/modules/lib --disable-noqa --count

[ ... ]
5737

[rmackay9]

The author ping'd me about this so I've added it to the EUDevCall. I'm not really qualified to review the PR

[peterbarker]

We use --show-source in run_flake8 - any reason not to include it here?

Note that cesium is external, but most, if not all, of MAVProxy/modules/lib is ours to clean. Why did you choose to exclude it entirely here rather than add the # flake8: noqa?

[cclauss]

Yes, let's add --show-source. (Ruff has no such option, so I have gotten out of the practice of adding it.)

https://github.com/ArduPilot/MAVProxy/tree/master/MAVProxy/modules says:

mavproxy_cesium @ 78f7be3

Therefore, the code in MAVProxy/modules/mavproxy_cesium is a git submodule and is not in this repository.

[peterbarker]

Please revert these patches. They are unrelated to the topic of the PR and don't improve things.

[cclauss]

The switch from -U to --upgrade is a self-documenting readability change. As I have stated in other ArduPilot PRs, pip install currently has six different --u* command-line options, including the often-used --user.

% python3 -m pip install --help | grep "\-\-u"

[peterbarker]

On Thu, 21 Aug 2025, Christian Clauss wrote: Therefore, the code in MAVProxy/modules/mavproxy_cesium is a git submodule and is not in this repository.

Correct, and we shouldn't check it. But the other directory being excluded is not a submodule - and it even has a couple of flake8-clean files...