Update Holybro X500 template #1203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Holybro X500 ArduCopter vehicle template to align with the current program version 2.9.5 and adds missing RSSI parameters to the default configuration.
Changes:
- Updated program version from 2.9.0 to 2.9.5 in vehicle_components.json
- Corrected tuning parameter values in tuning_report.csv to reflect actual configured values (ATC_ANG_*_P from 4.5 to 5.4)
- Added explanatory comments to GNSS/CAN parameters in 10_gnss.param
- Added six RSSI-related parameters to 00_default.param following the standard pattern used in other vehicle templates
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| vehicle_components.json | Updates program version to current 2.9.5 release |
| tuning_report.csv | Corrects documented ATC_ANG_*_P values to match actual 16_pid_adjustment.param settings (5.4) |
| 10_gnss.param | Adds clarifying comments for CAN and GPS configuration parameters |
| 00_default.param | Adds standard RSSI parameter defaults (6 parameters) between RPM2_TYPE and RSSI_TYPE |
Comment on lines
+3
to
+4
| CAN_D1_PROTOCOL,0 # Noting connected to CAN1 | ||
| CAN_P1_DRIVER,0 # Noting connected to CAN1 |
There was a problem hiding this comment.
Spelling error: "Noting" should be "Nothing".
Suggested change
| CAN_D1_PROTOCOL,0 # Noting connected to CAN1 | |
| CAN_P1_DRIVER,0 # Noting connected to CAN1 | |
| CAN_D1_PROTOCOL,0 # Nothing connected to CAN1 | |
| CAN_P1_DRIVER,0 # Nothing connected to CAN1 |
Comment on lines
+3
to
+4
| CAN_D1_PROTOCOL,0 # Noting connected to CAN1 | ||
| CAN_P1_DRIVER,0 # Noting connected to CAN1 |
There was a problem hiding this comment.
Spelling error: "Noting" should be "Nothing".
Suggested change
| CAN_D1_PROTOCOL,0 # Noting connected to CAN1 | |
| CAN_P1_DRIVER,0 # Noting connected to CAN1 | |
| CAN_D1_PROTOCOL,0 # Nothing connected to CAN1 | |
| CAN_P1_DRIVER,0 # Nothing connected to CAN1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.