GPS-SBF bug

[UAVcihang]

copter-4.6.3 gps driver AP_GPS_SBF.cpp have a bug

constexpr double doubleDNU = -2e-10;
should be doubleDNU = -2e+10;

[rmackay9]

Hi @UAVcihang,

Thanks for the report. So you must be referring to this line in the AP_GPS_SBF driver.

Could you give more information on why it is incorrect and/or what issue the bug causes?

FYI @WickedShell

[khancyr]

Hello,

that is indeed wrong : https://docs.sparkfun.com/SparkFun_GNSS_mosaic-X5/assets/component_documentation/firmware/mosaic-X5_Firmware_v4.15.0_Reference_Guide.pdf page 371.
Do you want to make a PR to correct this (and problably some other DNU field?)

[omarzayedbeshir]

#32633

[khancyr]

@omarzayedbeshir this hijacking behavior isn't correct, @UAVcihang find and report the issue, we should let him/her get the ownership of the fix

[omarzayedbeshir]

Sorry about that @UAVcihang and @khancyr, I should have waited. When the issue was reported, there was no PR for a few hours, so I went ahead and opened one. @UAVcihang, the fix is yours if you'd like to take it. I'm happy to close #32633 and let you submit your own PR.

[rmackay9]

I'm sure lots of people have different opinions but I don't think there's anything wrong with @omarzayedbeshir whipping up a PR as quickly as possible. The PR's not tested though so we need to find a way to do that.