domain-dependency-list - return 404 for unknown domains

[havetisyan]

Description

Contribution Checklist:

• The pull request does not introduce any breaking changes
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Attach Screenshots (Optional)

[gemini-code-assist]

Summary of Changes

Hello @havetisyan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the error handling within the ZMS service by modifying the getDependentServiceList API. It introduces a check to verify the existence of a requested domain and, if the domain is not found, it returns a 404 Not Found HTTP status code. This change improves API predictability and provides clearer feedback to clients about the status of their requests for non-existent resources.

Highlights

• API Behavior Change: The getDependentServiceList API in ZMSImpl.java now explicitly throws a 404 Not Found error when queried for a domain that does not exist in the system. Previously, it would return an empty list for such cases.
• Test Updates: The DomainDependencyTest has been updated to reflect this new behavior. The testDomainNotFound method now asserts that a 404 ResourceException is thrown when attempting to retrieve dependencies for an unknown domain, ensuring the new error handling is correctly tested.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly changes the getDependentServiceList API to return a 404 error for unknown domains instead of an empty list. This is a good improvement for API consistency and correctness. The implementation is straightforward, and the associated test is updated to reflect this new behavior. I've added a couple of suggestions to improve consistency in error message formatting and to make the test assertion more specific.