Hashmap instead of a linear search issue number is #1074 #1110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AtsushiSakai bro plz check pr |
Closed
AtsushiSakai
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Performance #1074
https://github.com/AtsushiSakai/PythonRobotics/blob/ad600cd9023e67cd8064b678213d6586d076dd15/PathPlanning/AStar/a_star_searching_from_two_side.py#L80C1-L117C20
In the referenced function, the search for coordinates and neighbors in
ob_listandneighborsoccurs frequently, especially for long obstacles. This change optimizes the process by storing obstacles and neighbors in a set. Sets use a hashmap for lookups, significantly improving efficiency compared to linear search. This modification aims to enhance performance in scenarios with long obstacle lists by reducing the time complexity of lookups