Skip to content

Conversation

Aglargil
Copy link
Contributor

@Aglargil Aglargil commented Feb 13, 2025

Reference issue

#411

What does this implement/fix?

  • Add the ElasticBands algorithm.
  • Add compute_sdf_scipy and compute_udf_scipy interfaces to Mapping.DistanceMap.

Additional information

The ElasticBands algorithm utilizes distance map. The original distance map was implemented in Python for educational purposes, taking approximately 3 seconds to process a 500*500 map on my machine. In contrast, scipy.ndimage.distance_transform_edt(implemented in C) completes the task in about 0.05 seconds. Therefore, to improve efficiency, the compute_sdf_scipy and compute_udf_scipy interfaces were added to Mapping.DistanceMap.

CheckList

  • Did you add an unittest for your new example or defect fix?
  • Did you add documents for your new example?
  • All CIs are green? (You can check it after submitting)

@Aglargil Aglargil changed the title WIP: feat: add ElasticBands feat: add ElasticBands Feb 15, 2025
@Aglargil
Copy link
Contributor Author

Hi, @AtsushiSakai
I am delighted to contribute the ElasticBands algorithm to this outstanding project. If you have any suggestions or feedback, please feel free to let me know—I will address them promptly.

Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank!!

@AtsushiSakai AtsushiSakai merged commit c92aaf3 into AtsushiSakai:master Feb 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants