Skip to content

Conversation

Aglargil
Copy link
Contributor

@Aglargil Aglargil commented Feb 19, 2025

Reference issue

fix #877

What does this implement/fix?

  • Update move_to_pose for cases where alpha > pi/2 or alpha < -pi/2
  • Format move_to_pose.py using Ruff

Additional information

Current results:
img_v3_02jl_e948e03d-773c-431a-81ec-7e74972d29ag

Previous results(master):
img_v3_02jl_5a226f00-9e2f-4b64-9cad-507cb12cc26g

CheckList

  • Did you add an unittest for your new example or defect fix?
  • Did you add documents for your new example?
  • All CIs are green? (You can check it after submitting)

Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!. Adding a test case is great, but if it is difficult, it is ok to merge. let me know.

Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!! @Aglargil

@AtsushiSakai AtsushiSakai merged commit f343573 into AtsushiSakai:master Feb 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

move_to_pose.py not consistent with book when alpha > pi/2

2 participants