fix(s3stream): fix the network out over-consumed #2752
Merged
+27
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the S3Stream network out consumption to ElasticReplicaManager. Avoid the network out traffic over-consumed, when there are mixin(tail read & catch-up read) partitions reading. Signed-off-by: Robin Han <[email protected]>
superhx
requested review from
Gezi-lzq,
1sonofqiu and
woshigaopp
as code owners
Gezi-lzq
approved these changes
Aug 13, 2025
superhx
added a commit
that referenced
this pull request
Aug 13, 2025
Consider the following scenario: A Fetch request contains partitions P1 and P2. The data of P1 is in LogCache, while the data of P2 is not. First, a fast read will be attempted. At this time, P1 will return data and consume Network Out, and P2 will return a FastReadException. Due to the FastReadException, the entire Fetch attempts a slow read. At this time, both P1 and P2 return data and consume Network Out. At this point, the Network Out in step 2 is consumed repeatedly. Solution: Move the S3Stream network out consumption to ElasticReplicaManager. Avoid the network out traffic over-consumed, when there are mixin(tail read & catch-up read) partitions reading. Signed-off-by: Robin Han <[email protected]>
superhx
added a commit
that referenced
this pull request
Aug 13, 2025
Consider the following scenario: 1. A Fetch request contains partitions P1 and P2. The data of P1 is in LogCache, while the data of P2 is not. 2. First, a fast read will be attempted. At this time, P1 will return data and consume Network Out, and P2 will return a FastReadException. 3. Due to the FastReadException, the entire Fetch attempts a slow read. At this time, both P1 and P2 return data and consume Network Out. 4. At this point, the Network Out in step 2 is consumed repeatedly. Solution: Move the S3Stream network out consumption to ElasticReplicaManager. Avoid the network out traffic over-consumed, when there are mixin(tail read & catch-up read) partitions reading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following scenario:
Solution: Move the S3Stream network out consumption to ElasticReplicaManager. Avoid the network out traffic over-consumed, when there are mixin(tail read & catch-up read) partitions reading.