Only attempt to install pods when linting strings if CP is found#136
Merged
Only attempt to install pods when linting strings if CP is found#136
Conversation
As we start removing CocoaPods from some of our projects, we can no longer assume pods exist locally to install. See wordpress-mobile/WordPress-iOS#23951 which prompted this change.
mokagio
commented
Jan 7, 2025
Comment on lines
15
to
+20
| echo "--- :cocoapods: Setting up Pods" | ||
| install_cocoapods | ||
| if [[ -f Podfile.lock ]]; then | ||
| install_cocoapods | ||
| else | ||
| echo "CocoaPods setup not detected. Skipping CocoaPods installation..." | ||
| fi |
Contributor
Author
There was a problem hiding this comment.
I considered moving the header (--- :cocoapods:...) in the if too, but I thought it useful to show it in the logs even when the action is skipped. What do you think?
AliSoftware
approved these changes
Jan 7, 2025
Comment on lines
15
to
+20
| echo "--- :cocoapods: Setting up Pods" | ||
| install_cocoapods | ||
| if [[ -f Podfile.lock ]]; then | ||
| install_cocoapods | ||
| else | ||
| echo "CocoaPods setup not detected. Skipping CocoaPods installation..." | ||
| fi |
mokagio
added a commit
that referenced
this pull request
Feb 3, 2025
As we start removing CocoaPods from some of our projects, we can no longer assume pods exist locally to install. See wordpress-mobile/WordPress-iOS#23951 which prompted this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we start removing CocoaPods from some of our projects, we can no longer assume pods exist locally to install.
See wordpress-mobile/WordPress-iOS#23951 which prompted this change.
Example in action: https://buildkite.com/automattic/wordpress-ios/builds/25292#01943fbf-a124-4d9e-910a-b1cb8871bfcb
CHANGELOG.mdif necessary.