Skip to content

Only attempt to install pods when linting strings if CP is found #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mokagio merged 2 commits into from
Jan 7, 2025
Merged

Only attempt to install pods when linting strings if CP is found #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a53de7
Only attempt to install pods when linting strings if CP is found
mokagio Jan 7, 2025
57d8ac1
Add `CHANGELOG` entry for new localizations lint behavior
mokagio Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ _None._

### New Features

_None._
- `lint_localized_strings_format` will bypass CocoaPods if a `Podfile.lock` is not found [#136]

### Bug Fixes

Expand Down
6 changes: 5 additions & 1 deletion bin/lint_localized_strings_format
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ install_gems
# The strings generation also picks up files from our first party libraries,
# some of which are installed via CocoaPods
echo "--- :cocoapods: Setting up Pods"
install_cocoapods
if [[ -f Podfile.lock ]]; then
install_cocoapods
else
echo "CocoaPods setup not detected. Skipping CocoaPods installation..."
fi
Comment on lines 15 to +20
Copy link
Contributor Author

@mokagio mokagio Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered moving the header (--- :cocoapods:...) in the if too, but I thought it useful to show it in the logs even when the action is skipped. What do you think?

Copy link
Contributor

@AliSoftware AliSoftware Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed 👍


echo "--- :sleuth_or_spy: Lint Apple Localized Strings Format"
# A next step improvement is to move the logs management within the release
Expand Down
Loading