Skip to content

fix: prevent negative slice index in populate subdocPath calculation #15862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

fix: prevent negative slice index in populate subdocPath calculation #15862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/helpers/populate/getModelsMapForPopulate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ module.exports = function getModelsMapForPopulate(model, docs, options) {
modelNames = [modelNameFromQuery]; // query options
} else if (refPath != null) {
if (typeof refPath === 'function') {
const subdocPath = options.path.slice(0, options.path.length - schema.path.length - 1);
const subdocPath = options.path.slice(0, Math.max(0, options.path.length - schema.path.length - 1));
const vals = mpath.get(subdocPath, doc, lookupLocalFields);
const subdocsBeingPopulated = Array.isArray(vals) ?
utils.array.flatten(vals) :
Expand Down Expand Up @@ -301,7 +301,7 @@ module.exports = function getModelsMapForPopulate(model, docs, options) {
// Ensure correct context for ref functions: subdoc, not top-level doc. See gh-8469
modelNames = new Set();

const subdocPath = options.path.slice(0, options.path.length - schemaForCurrentDoc.path.length - 1);
const subdocPath = options.path.slice(0, Math.max(0, options.path.length - schemaForCurrentDoc.path.length - 1));
const vals = mpath.get(subdocPath, doc, lookupLocalFields);
const subdocsBeingPopulated = Array.isArray(vals) ?
utils.array.flatten(vals) :
Expand All @@ -322,7 +322,7 @@ module.exports = function getModelsMapForPopulate(model, docs, options) {
} else if ((schemaForCurrentDoc = get(schema, 'options.refPath')) != null) {
isRefPath = true;
if (typeof refPath === 'function') {
const subdocPath = options.path.slice(0, options.path.length - schemaForCurrentDoc.path.length - 1);
const subdocPath = options.path.slice(0, Math.max(0, options.path.length - schemaForCurrentDoc.path.length - 1));
const vals = mpath.get(subdocPath, doc, lookupLocalFields);
const subdocsBeingPopulated = Array.isArray(vals) ?
utils.array.flatten(vals) :
Expand Down