chore(aggregate): use MongooseError instead of Error#16095
Open
mahmoodhamdi wants to merge 1 commit intoAutomattic:masterfrom
Open
chore(aggregate): use MongooseError instead of Error#16095mahmoodhamdi wants to merge 1 commit intoAutomattic:masterfrom
mahmoodhamdi wants to merge 1 commit intoAutomattic:masterfrom
Conversation
Replace 7 instances of `throw new Error(...)` with `throw new MongooseError(...)` in lib/aggregate.js for consistency. MongooseError extends Error so this is backward-compatible for any code catching generic Error instances. Re: Automattic#15995
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces 7 instances of
throw new Error(...)withthrow new MongooseError(...)inlib/aggregate.jsas part of the effort to standardize error types across the codebase.MongooseErrorextendsError, so this is backward-compatible for any code catching genericErrorinstances.Changed methods:
append()— invalid pipeline operatoraddFields()— invalid argument typeproject()— invalid argument typeunwind()— invalid argument typeredact()— invalid thenExpr/elseExpr valueexplain()— empty pipelineexec()— aggregate not bound to modelTesting
All 118 aggregate-related tests pass. Verified that thrown errors are
instanceof MongooseErrorand stillinstanceof Error.Re: #15995