Skip to content

chore(aggregate): use MongooseError instead of Error #16095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mahmoodhamdi wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −7
Open

chore(aggregate): use MongooseError instead of Error #16095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions lib/aggregate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ Aggregate.prototype.append = function() {
: [...arguments];

if (!args.every(isOperator)) {
throw new Error('Arguments must be aggregate pipeline operators');
throw new MongooseError('Arguments must be aggregate pipeline operators');
}

this._pipeline = this._pipeline.concat(args);
Expand Down Expand Up @@ -203,7 +203,7 @@ Aggregate.prototype.append = function() {
*/
Aggregate.prototype.addFields = function(arg) {
if (typeof arg !== 'object' || arg === null || Array.isArray(arg)) {
throw new Error('Invalid addFields() argument. Must be an object');
throw new MongooseError('Invalid addFields() argument. Must be an object');
}
return this.append({ $addFields: Object.assign({}, arg) });
};
Expand Down Expand Up @@ -259,7 +259,7 @@ Aggregate.prototype.project = function(arg) {
fields[field] = include;
});
} else {
throw new Error('Invalid project() argument. Must be string or object');
throw new MongooseError('Invalid project() argument. Must be string or object');
}

return this.append({ $project: fields });
Expand Down Expand Up @@ -462,7 +462,7 @@ Aggregate.prototype.unwind = function() {
$unwind: (arg[0] === '$') ? arg : '$' + arg
});
} else {
throw new Error('Invalid arg "' + arg + '" to unwind(), ' +
throw new MongooseError('Invalid arg "' + arg + '" to unwind(), ' +
'must be string or object');
}
}
Expand Down Expand Up @@ -761,7 +761,7 @@ Aggregate.prototype.redact = function(expression, thenExpr, elseExpr) {
if (arguments.length === 3) {
if ((typeof thenExpr === 'string' && !validRedactStringValues.has(thenExpr)) ||
(typeof elseExpr === 'string' && !validRedactStringValues.has(elseExpr))) {
throw new Error('If thenExpr or elseExpr is string, it must be either $$DESCEND, $$PRUNE or $$KEEP');
throw new MongooseError('If thenExpr or elseExpr is string, it must be either $$DESCEND, $$PRUNE or $$KEEP');
}

expression = {
Expand Down Expand Up @@ -796,7 +796,7 @@ Aggregate.prototype.explain = async function explain(verbosity) {
const model = this._model;

if (!this._pipeline.length) {
throw new Error('Aggregate has empty pipeline');
throw new MongooseError('Aggregate has empty pipeline');
}

prepareDiscriminatorPipeline(this._pipeline, this._model.schema);
Expand Down Expand Up @@ -1058,7 +1058,7 @@ Aggregate.prototype.pipelineForUnionWith = function pipelineForUnionWith() {

Aggregate.prototype.exec = async function exec() {
if (!this._model && !this._connection) {
throw new Error('Aggregate not bound to any Model');
throw new MongooseError('Aggregate not bound to any Model');
}
if (typeof arguments[0] === 'function') {
throw new MongooseError('Aggregate.prototype.exec() no longer accepts a callback');
Expand Down