Skip to content

Conversation

@leogermani
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Tracking is only meant to track Ads. We only track clicks on ads. We only show the number on ads. We need the settings screen to reflect that.

How to test the changes in this Pull Request:

  1. Visit Newsletters > Advertising and confirm you see a new tab called "Tracking"
image
  1. Click that link and confirm you are taken to Settings > Ads Tracking
image
  1. Confirm all the copy look good

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani requested a review from a team as a code owner December 11, 2025 21:53
@leogermani leogermani self-assigned this Dec 11, 2025
@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Dec 11, 2025
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Dec 12, 2025
@leogermani leogermani merged commit 3da6434 into trunk Dec 15, 2025
9 checks passed
@leogermani leogermani deleted the feat/move-and-rename-newsletter-tracking branch December 15, 2025 19:12
@github-actions
Copy link

Hey @leogermani, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants