Skip to content

feat: rename newsletter tracking #4358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leogermani merged 1 commit into from
Dec 15, 2025
+10 −5
Merged

feat: rename newsletter tracking #4358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions includes/wizards/class-newsletters-wizard.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,11 @@ private function get_tabs() {
];
}

$tabs[] = [
'textContent' => esc_html__( 'Tracking', 'newspack-plugin' ),
'href' => admin_url( 'edit.php?post_type=' . Newspack_Newsletters::NEWSPACK_NEWSLETTERS_CPT . '&page=' . $this->slug . '#/tracking' ),
];

return $tabs;
}

Expand Down
2 changes: 1 addition & 1 deletion src/wizards/newsletters/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class NewslettersWizard extends Component {
path: '/',
},
{
label: __( 'Tracking', 'newspack-plugin' ),
label: __( 'Ads Tracking', 'newspack-plugin' ),
path: '/tracking',
},
];
Expand Down
8 changes: 4 additions & 4 deletions src/wizards/newsletters/views/tracking/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,17 @@ export default withWizardScreen( () => {

return (
<>
<h1>{ __( 'Tracking', 'newspack-plugin' ) }</h1>
<h1>{ __( 'Ads Tracking', 'newspack-plugin' ) }</h1>
<ActionCard
title={ __( 'Click-tracking', 'newspack-plugin' ) }
description={ __( 'Track the clicks on the links in your newsletter.', 'newspack-plugin' ) }
description={ __( 'Track the clicks on ads in your newsletter.', 'newspack-plugin' ) }
disabled={ inFlight }
toggleOnChange={ handleChange( 'click' ) }
toggleChecked={ tracking.click }
/>
<ActionCard
title={ __( 'Tracking pixel', 'newspack-plugin' ) }
description={ __( 'Track the opens of your newsletter.', 'newspack-plugin' ) }
title={ __( 'Ads impressions', 'newspack-plugin' ) }
description={ __( 'Track the impressions of ads in your newsletter.', 'newspack-plugin' ) }
disabled={ inFlight }
toggleOnChange={ handleChange( 'pixel' ) }
toggleChecked={ tracking.pixel }
Expand Down