Skip to content

Conversation

@miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

NPPM-2441

The current strategy to infer and set a default provider in the PlacementControl component doesn't play well when the initial state is an invalid option. The UI will show the default value, but never trigger the change, which will mislead the user.

This PR fixes this behavior by removing the default provider.

How to test the changes in this Pull Request:

  1. While on trunk, make sure you have GAM and Broadstreet configured and enabled
  2. Set some global placements to use GAM
  3. Deactivate the GAM provider
  4. Edit the placement and confirm that it automatically shows Broadstreet as the provider
  5. Confirm that saving the placement doesn't change its value in the database
  6. Checkout this branch, refresh the page and edit the placement again
  7. Confirm it shows "Select a provider"
  8. Set Broadstreet, choose an ad unit, and save
  9. Confirm the values are updated in the database

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe self-assigned this Jan 5, 2026
@miguelpeixe miguelpeixe requested a review from a team as a code owner January 5, 2026 20:21
@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 5, 2026
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 6, 2026
@miguelpeixe miguelpeixe merged commit 72d7b68 into trunk Jan 6, 2026
9 checks passed
@miguelpeixe miguelpeixe deleted the fix/ads-placement-control branch January 6, 2026 13:18
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Hey @miguelpeixe, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants