Skip to content

fix(ads): placement control value reset #4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelpeixe merged 1 commit into from
Jan 6, 2026
+16 −9
Merged

fix(ads): placement control value reset #4375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions src/wizards/advertising/components/placement-control/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/**
* WordPress dependencies
*/
import { Fragment, useState, useEffect } from '@wordpress/element';
import { Fragment, useState, useEffect, useMemo } from '@wordpress/element';
import { __, sprintf } from '@wordpress/i18n';

/**
Expand Down Expand Up @@ -87,17 +87,24 @@ const PlacementControl = ( {
} ) => {
const [ biddersErrors, setBiddersErrors ] = useState( {} );

// Default provider is GAM or first index if GAM is not active.
const placementProvider = providers.find( provider => provider?.id === ( value.provider || 'gam' ) ) || providers[ 0 ];
// Ensure incoming value is available otherwise reset to empty values.
const placementProvider = useMemo(
() => ( value.provider ? providers.find( provider => provider?.id === value.provider ) : null ),
[ providers, value.provider ]
);
const placementAdUnit = useMemo(
() => ( value.ad_unit ? ( placementProvider?.units || [] ).find( u => u.value === value.ad_unit ) : null ),
[ placementProvider, value.ad_unit ]
);

useEffect( () => {
const errors = {};
Object.keys( bidders ).forEach( bidderKey => {
const bidder = bidders[ bidderKey ];
const unit = placementProvider?.units.find( u => u.value === value.ad_unit );
const supported = value.ad_unit && unit && hasAnySize( bidder.ad_sizes, unit.sizes );
const unit = placementAdUnit;
const supported = placementAdUnit && unit && hasAnySize( bidder.ad_sizes, unit.sizes );
errors[ bidderKey ] =
! value.ad_unit || ! unit || supported
! placementAdUnit || ! unit || supported
? null
: sprintf(
// translators: %s: ad bidder name.
Expand All @@ -107,7 +114,7 @@ const PlacementControl = ( {
);
} );
setBiddersErrors( errors );
}, [ providers, value.ad_unit ] );
}, [ placementProvider, placementAdUnit ] );

if ( ! providers.length ) {
return <Notice isWarning noticeText={ __( 'There is no provider available.', 'newspack-plugin' ) } />;
Expand All @@ -118,14 +125,14 @@ const PlacementControl = ( {
<Grid columns={ 2 } gutter={ 32 }>
<SelectControl
label={ __( 'Provider', 'newspack-plugin' ) }
value={ placementProvider?.id ?? '' }
value={ placementProvider ? placementProvider.id : '' }
options={ getProvidersForSelect( providers ) }
onChange={ provider => onChange( { ...value, provider } ) }
disabled={ disabled }
/>
<SelectControl
label={ label }
value={ value?.ad_unit ?? '' }
value={ placementAdUnit ? placementAdUnit.value : '' }
options={ getProviderUnitsForSelect( placementProvider ) }
onChange={ data => {
onChange( {
Expand Down