-
Notifications
You must be signed in to change notification settings - Fork 54
Sync: Add offline status indicator to push progress UI #2373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync: Add offline status indicator to push progress UI #2373
Conversation
📊 Performance Test ResultsComparing c74ada4 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
ivan-ottinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
katinthehatsite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me 👍 I left one minor comment regarding the wording.
Co-authored-by: katinthehatsite <[email protected]>
epeicher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gavande1 for improving this, I have tested it, and it works as expected. LGTM! ![]()

Related issues
Proposed Changes
Testing Instructions
Screenshot
Pre-merge Checklist