Skip to content

Conversation

@gavande1
Copy link
Contributor

@gavande1 gavande1 commented Jan 9, 2026

Related issues

Proposed Changes

  • Shows offline icon instead of info icon when user is offline during push
  • Updated tooltip message to explain offline status and that sync will continue remotely

Testing Instructions

  1. Start a push sync operation
  2. Let the upload phase complete
  3. When remote backup phase starts, disconnect from the internet (turn off WiFi/network)
  4. Observe the push progress UI - it should now show:
    • An offline icon (cloud with slash) instead of the info icon
    • A tooltip explaining the offline status: "Your internet connection appears to be offline. Sync will continue running remotely. We will send you an email once it's completed."
  5. Reconnect to the internet and verify the icon changes back to the info icon

Screenshot

CleanShot 2026-01-09 at 15 14 38@2x

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@gavande1 gavande1 self-assigned this Jan 9, 2026
@gavande1 gavande1 requested a review from a team January 9, 2026 09:52
@gavande1 gavande1 changed the title Add offline status indicator to push progress UI Sync: Add offline status indicator to push progress UI Jan 9, 2026
@wpmobilebot
Copy link

wpmobilebot commented Jan 9, 2026

📊 Performance Test Results

Comparing c74ada4 vs trunk

site-editor

Metric trunk c74ada4 Diff Change
load 7509.00 ms 5845.00 ms -1664.00 ms 🟢 -22.2%

site-startup

Metric trunk c74ada4 Diff Change
siteCreation 16114.00 ms 9055.00 ms -7059.00 ms 🟢 -43.8%
siteStartup 3947.00 ms 3947.00 ms 0.00 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works as expected. ✅

Despite many users won't get to see this message, I think it is a helpful improvement for those who will. 🙂

Image

Copy link
Contributor

@katinthehatsite katinthehatsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me 👍 I left one minor comment regarding the wording.

Co-authored-by: katinthehatsite <[email protected]>
Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gavande1 for improving this, I have tested it, and it works as expected. LGTM! :shipit:

Image

@gavande1 gavande1 merged commit 1b8f69e into trunk Jan 9, 2026
9 checks passed
@gavande1 gavande1 deleted the stu-1195-add-offline-status-to-other-state-for-push-progress branch January 9, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants