Skip to content

Sync: Add offline status indicator to push progress UI #2373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gavande1 merged 2 commits into from
Jan 9, 2026
Merged

Sync: Add offline status indicator to push progress UI #2373

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4f2426
Add offline status indicator to push progress UI
gavande1 Jan 9, 2026
c74ada4
Update message
gavande1 Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions src/modules/sync/components/sync-connected-sites.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ const SyncConnectedSitesSectionItem = ( {
connectedSite,
}: SyncConnectedSitesListProps ) => {
const { __ } = useI18n();
const isOffline = useOffline();
const { clearPullState, getPullState, getPushState, clearPushState, cancelPull, cancelPush } =
useSyncSites();
const { importState } = useImportExport();
Expand Down Expand Up @@ -224,6 +225,20 @@ const SyncConnectedSitesSectionItem = ( {
pushState?.uploadProgress
);

const getPushProgressTooltip = () => {
if ( isOffline ) {
return __(
"You are currently offline. Sync will continue running remotely. We will send you an email once it's completed."
);
}
if ( pushBackupIsUploading( pushState?.status.key ) ) {
return __( 'Push is in progress. We will send you an email when it is completed.' );
}
return __(
"The push is in progress and will continue running remotely. We will send you an email once it's completed."
);
};

return (
<div className="grid grid-cols-[max-content_1fr_max-content]">
<div
Expand Down Expand Up @@ -312,19 +327,14 @@ const SyncConnectedSitesSectionItem = ( {
) }
{ pushState?.status && isPushing && (
<div className="flex items-center gap-2 max-w-full">
<Tooltip
text={
pushBackupIsUploading( pushState?.status.key )
? __( 'Push is in progress. We will send you an email when it is completed.' )
: __(
"The push is in progress and will continue running remotely. We will send you an email once it's completed."
)
}
placement="top-start"
>
<Tooltip text={ getPushProgressTooltip() } placement="top-start">
<div className="flex flex-col gap-2 min-w-44 flex-shrink">
<div className="a8c-body-small flex items-center gap-0.5">
<Icon icon={ info } size={ 16 } />
{ isOffline ? (
<Icon icon={ offlineIcon } size={ 12 } className="fill-a8c-gray-70" />
) : (
<Icon icon={ info } size={ 14 } />
) }
{ getPushUploadMessage( pushState.status.message, uploadPercentage ) }
</div>
<ProgressBar value={ pushState.status.progress } maxValue={ 100 } />
Expand Down