fix: rename feature path functions and update global declarations#1303
Merged
Azgaar merged 2 commits intoAzgaar:masterfrom Feb 3, 2026
Merged
Conversation
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors two renderer modules to align with the established TypeScript migration pattern in the codebase. Internal function names are updated to use the *Renderer suffix while maintaining backward compatibility by exposing them globally with their original names.
Changes:
- Renamed internal
drawMarkertomarkerRendererindraw-markers.tsand exposed it aswindow.drawMarker - Renamed internal
getFeaturePathtofeaturePathRendererindraw-features.tsand exposed it aswindow.getFeaturePath - Added corresponding global type declarations for both functions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/renderers/draw-markers.ts | Renamed internal function to markerRenderer following the *Renderer pattern, added global declaration and window assignment for drawMarker |
| src/renderers/draw-features.ts | Renamed internal function to featurePathRenderer following the *Renderer pattern, added global declaration and window assignment for getFeaturePath |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Versioning
NOT NEEDED IN TS FILES <3