Skip to content

fix: rename feature path functions and update global declarations #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Azgaar merged 2 commits into from
Feb 3, 2026
Merged

fix: rename feature path functions and update global declarations #1303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fc218d
fix: rename feature path functions and update global declarations
SheepFromHeaven Feb 3, 2026
3bf4e31
chore: lint
SheepFromHeaven Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/renderers/draw-features.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ declare global {
tolerance: number,
highestQuality?: boolean,
) => [number, number][];
var getFeaturePath: (feature: PackedGraphFeature) => string;
}

interface FeaturesHtml {
Expand All @@ -34,7 +35,7 @@ const featuresRenderer = (): void => {
if (!feature || feature.type === "ocean") continue;

html.paths.push(
`<path d="${getFeaturePath(feature)}" id="feature_${feature.i}" data-f="${feature.i}"></path>`,
`<path d="${featurePathRenderer(feature)}" id="feature_${feature.i}" data-f="${feature.i}"></path>`,
);

if (feature.type === "lake") {
Expand Down Expand Up @@ -81,7 +82,7 @@ const featuresRenderer = (): void => {
TIME && console.timeEnd("drawFeatures");
};

function getFeaturePath(feature: PackedGraphFeature): string {
function featurePathRenderer(feature: PackedGraphFeature): string {
const points: [number, number][] = feature.vertices.map(
(vertex: number) => pack.vertices.p[vertex],
);
Expand All @@ -100,3 +101,4 @@ function getFeaturePath(feature: PackedGraphFeature): string {
}

window.drawFeatures = featuresRenderer;
window.getFeaturePath = featurePathRenderer;
6 changes: 4 additions & 2 deletions src/renderers/draw-markers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ interface Marker {

declare global {
var drawMarkers: () => void;
var drawMarker: (marker: Marker, rescale?: number) => string;
}

type PinShapeFunction = (fill: string, stroke: string) => string;
Expand Down Expand Up @@ -56,7 +57,7 @@ const getPin = (shape = "bubble", fill = "#fff", stroke = "#000"): string => {
return shapeFunction(fill, stroke);
};

function drawMarker(marker: Marker, rescale = 1): string {
function markerRenderer(marker: Marker, rescale = 1): string {
const {
i,
icon,
Expand Down Expand Up @@ -94,10 +95,11 @@ const markersRenderer = (): void => {
const markersData: Marker[] = pinned
? pack.markers.filter((m: Marker) => m.pinned)
: pack.markers;
const html = markersData.map((marker) => drawMarker(marker, rescale));
const html = markersData.map((marker) => markerRenderer(marker, rescale));
markers.html(html.join(""));

TIME && console.timeEnd("drawMarkers");
};

window.drawMarkers = markersRenderer;
window.drawMarker = markerRenderer;
Loading