Skip to content

Conversation

@just-mitch
Copy link
Collaborator

@just-mitch just-mitch commented Aug 24, 2025

Add Scenario Network Deployment Workflow

This PR adds a new workflow for deploying a complete scenario network, which includes:

  1. A new deploy-scenario-network.yml workflow that orchestrates the deployment of both an Ethereum devnet and rollup contracts

  2. Updates to the deploy-eth-devnet.yml workflow to:

    • Accept a custom mnemonic as an input parameter
    • Expose deployment results (RPC URL, WebSocket URL, Beacon URL, Chain ID) as workflow outputs
    • Mask the mnemonic in logs for security
  3. Updates to the Terraform configuration in deploy-eth-devnet:

    • Use the provided mnemonic instead of fetching from Google Secret Manager
    • Support both static IPs and cluster IPs for services
    • Add proper output handling for both IP types
  4. Updates to the rollup contracts deployment to properly use the validators parameter

These changes enable more flexible and composable deployment workflows for testing scenarios.

Copy link
Collaborator Author

just-mitch commented Aug 24, 2025

@just-mitch just-mitch changed the title mitch/tmnt-194-scaffold-deploy-scenario-networkyml feat: scaffold deploy-scenario-network.yml Aug 24, 2025
@just-mitch just-mitch marked this pull request as ready for review August 24, 2025 14:15
@just-mitch just-mitch requested a review from charlielye as a code owner August 24, 2025 14:15
@just-mitch just-mitch force-pushed the 08-24-mitch_tmnt-194-scaffold-deploy-scenario-networkyml branch from dad9d14 to 5bf3ad7 Compare August 25, 2025 10:57
@just-mitch just-mitch force-pushed the 08-23-mitch_tmnt-166-create-deploy-rollup-contractsyml branch from 0f5a5e6 to ed3868b Compare August 26, 2025 18:20
@just-mitch just-mitch force-pushed the 08-24-mitch_tmnt-194-scaffold-deploy-scenario-networkyml branch from 5bf3ad7 to 3efd44c Compare August 26, 2025 18:20
@just-mitch just-mitch force-pushed the 08-23-mitch_tmnt-166-create-deploy-rollup-contractsyml branch from ed3868b to 4625b9d Compare August 26, 2025 19:42
@just-mitch just-mitch force-pushed the 08-24-mitch_tmnt-194-scaffold-deploy-scenario-networkyml branch 2 times, most recently from be9395d to 72f6625 Compare August 27, 2025 12:26
@just-mitch just-mitch force-pushed the 08-23-mitch_tmnt-166-create-deploy-rollup-contractsyml branch 2 times, most recently from 2f88902 to 9fab426 Compare August 27, 2025 14:50
@just-mitch just-mitch force-pushed the 08-24-mitch_tmnt-194-scaffold-deploy-scenario-networkyml branch from 72f6625 to 6d00759 Compare August 27, 2025 14:50
@just-mitch just-mitch force-pushed the 08-23-mitch_tmnt-166-create-deploy-rollup-contractsyml branch from 9fab426 to 1c7563b Compare August 27, 2025 23:46
@just-mitch just-mitch force-pushed the 08-24-mitch_tmnt-194-scaffold-deploy-scenario-networkyml branch from 6d00759 to 050f8f1 Compare August 27, 2025 23:46
Comment on lines +62 to +66
mnemonic:
description: The mnemonic to use for the eth devnet
required: false
type: string
default: "test test test test test test test test test test test junk"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be moved to the secret section of the workflow?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. If we only wanted it to be called via workflow_call, I'd say yes. But if we move it to secrets, then effectively whenever someone wants to manually dispatch, they'll be using the mnemonic stored in the repo, which I don't think is what we want.

@just-mitch just-mitch force-pushed the 08-24-mitch_tmnt-194-scaffold-deploy-scenario-networkyml branch from 050f8f1 to f30a344 Compare August 28, 2025 18:40
@just-mitch just-mitch force-pushed the 08-23-mitch_tmnt-166-create-deploy-rollup-contractsyml branch from 1c7563b to 79f0f2b Compare August 28, 2025 18:40
Base automatically changed from 08-23-mitch_tmnt-166-create-deploy-rollup-contractsyml to next August 28, 2025 19:36
@just-mitch just-mitch added this pull request to the merge queue Aug 28, 2025
Merged via the queue into next with commit 470f10c Aug 28, 2025
11 of 12 checks passed
@just-mitch just-mitch deleted the 08-24-mitch_tmnt-194-scaffold-deploy-scenario-networkyml branch August 28, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants