Skip to content

Comments

feat: create deploy-aztec-infra.yml#16580

Merged
just-mitch merged 1 commit intonextfrom
08-25-mitch_tmnt-167-create-deploy-aztec-infrayml
Aug 29, 2025
Merged

feat: create deploy-aztec-infra.yml#16580
just-mitch merged 1 commit intonextfrom
08-25-mitch_tmnt-167-create-deploy-aztec-infrayml

Conversation

@just-mitch
Copy link
Collaborator

@just-mitch just-mitch commented Aug 26, 2025

Add Deploy Aztec Infra Workflow and Refactor Deployment Workflows

One can:

lwfl deploy_scenario_network --input cluster=kind --input namespace=your-scenario​
# or
lwfl deploy_scenario_network --input cluster=aztec-gke-private --input namespace=your-scenario​

To get:

  • an eth devnet
  • gov and rollup contracts deployed
  • aztec L2 infratructure deployed on top:
    • validators
    • rpc node
    • p2p bootstrap
    • prover stack

I renamed the deploy-staging-testnet​ to the more generic deploy-aztec-infra​, and made it correspondingly configurable.

Fix TMNT-178

AI Generated Summary

This PR adds a new GitHub workflow for deploying Aztec infrastructure and refactors existing deployment workflows to improve consistency and maintainability:

  1. Added deploy-aztec-infra.yml workflow that:
    • Deploys a complete Aztec network infrastructure including P2P bootstrap nodes, validators, provers, and RPC nodes
    • Accepts configurable parameters for cluster, namespace, docker image, L1 connections, contract addresses, and resource profiles
  2. Refactored existing deployment workflows:
    • Made required parameters explicitly required instead of using defaults
    • Added output variables to the rollup contracts deployment workflow to pass contract addresses to dependent workflows
    • Updated the scenario network deployment to use the new Aztec infra workflow
  3. Improved Terraform configurations:
    • Reorganized the staging testnet Terraform to use a more modular approach with separate value files for different resource profiles
    • Simplified configuration by using dynamic blocks and local variables
    • Added support for local Terraform state for easier testing
    • Removed lifecycle blocks that prevented resource destruction
  4. Enhanced deployment workflow integration:
    • Connected the ETH devnet, rollup contracts, and Aztec infra workflows in the scenario network deployment
    • Added support for prefunded mnemonic indices in the ETH devnet

These changes make the deployment process more flexible, maintainable, and consistent across different environments.

Copy link
Collaborator Author

just-mitch commented Aug 26, 2025

@just-mitch just-mitch force-pushed the 08-25-mitch_tmnt-167-create-deploy-aztec-infrayml branch from 28663c7 to cb04b73 Compare August 26, 2025 13:15
@just-mitch just-mitch changed the title mitch/tmnt-167-create-deploy-aztec-infrayml feat: create deploy-aztec-infra.yml Aug 26, 2025
@just-mitch just-mitch force-pushed the 08-25-mitch_tmnt-167-create-deploy-aztec-infrayml branch from cb04b73 to 02eb380 Compare August 26, 2025 13:27
@just-mitch just-mitch marked this pull request as ready for review August 26, 2025 13:29
@just-mitch just-mitch requested a review from charlielye as a code owner August 26, 2025 13:29
@just-mitch just-mitch force-pushed the 08-24-mitch_tmnt-194-scaffold-deploy-scenario-networkyml branch from 5bf3ad7 to 3efd44c Compare August 26, 2025 18:20
@just-mitch just-mitch force-pushed the 08-25-mitch_tmnt-167-create-deploy-aztec-infrayml branch from 02eb380 to 5a5acc4 Compare August 26, 2025 18:20
@just-mitch just-mitch force-pushed the 08-25-mitch_tmnt-167-create-deploy-aztec-infrayml branch from 5a5acc4 to a658ea6 Compare August 26, 2025 19:42
@just-mitch just-mitch force-pushed the 08-24-mitch_tmnt-194-scaffold-deploy-scenario-networkyml branch 2 times, most recently from be9395d to 72f6625 Compare August 27, 2025 12:26
@just-mitch just-mitch force-pushed the 08-25-mitch_tmnt-167-create-deploy-aztec-infrayml branch 2 times, most recently from a291c1e to 8416064 Compare August 27, 2025 14:50
@just-mitch just-mitch force-pushed the 08-24-mitch_tmnt-194-scaffold-deploy-scenario-networkyml branch 2 times, most recently from 6d00759 to 050f8f1 Compare August 27, 2025 23:46
@just-mitch just-mitch force-pushed the 08-25-mitch_tmnt-167-create-deploy-aztec-infrayml branch from 8416064 to 62c5da5 Compare August 27, 2025 23:46
Copy link
Contributor

@alexghr alexghr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I'm a bit worried about removing the destruction protection on IP addresses since that would release those IPs to be used by something else but maybe we don't need to be so strict about them

Comment on lines +132 to +133
resource "helm_release" "releases" {
for_each = local.helm_releases
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very elegant approach!

@just-mitch just-mitch force-pushed the 08-24-mitch_tmnt-194-scaffold-deploy-scenario-networkyml branch from 050f8f1 to f30a344 Compare August 28, 2025 18:40
@just-mitch just-mitch force-pushed the 08-25-mitch_tmnt-167-create-deploy-aztec-infrayml branch from 62c5da5 to 80094b3 Compare August 28, 2025 18:40
Base automatically changed from 08-24-mitch_tmnt-194-scaffold-deploy-scenario-networkyml to next August 28, 2025 23:02
@just-mitch just-mitch force-pushed the 08-25-mitch_tmnt-167-create-deploy-aztec-infrayml branch from 80094b3 to bec0c58 Compare August 29, 2025 00:54
@just-mitch just-mitch added this pull request to the merge queue Aug 29, 2025
Merged via the queue into next with commit 5c178eb Aug 29, 2025
16 checks passed
@just-mitch just-mitch deleted the 08-25-mitch_tmnt-167-create-deploy-aztec-infrayml branch August 29, 2025 01:47
ludamad pushed a commit that referenced this pull request Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants