feat: update noir to use msgpack-compact serialization format#19041
Closed
ludamad wants to merge 7 commits intomerge-train/barretenbergfrom
Closed
feat: update noir to use msgpack-compact serialization format#19041ludamad wants to merge 7 commits intomerge-train/barretenbergfrom
ludamad wants to merge 7 commits intomerge-train/barretenbergfrom
Conversation
ludamad
force-pushed
the
adam/feat/msgpack-compact-bb
branch
from
7a17e7f to
da4bcd0
Compare
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
Updates the noir submodule to noir-lang/noir#10878 which adds C++ codegen support for msgpack-compact serialization format. Also exports NOIR_SERIALIZATION_FORMAT=msgpack-compact in source_bootstrap. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
ludamad
force-pushed
the
adam/feat/msgpack-compact-bb
branch
2 times, most recently
from
b8cfbb7 to
de815bd
Compare
Copy the foundry cache folder to a temporary location before running forge scripts to avoid conflicts when multiple deployments run in parallel. The cache folder is small metadata that links to the out folder, so this is a fast operation. Also write broadcasts to the temp cache folder. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
ludamad
force-pushed
the
adam/feat/msgpack-compact-bb
branch
from
de815bd to
ce59c56
Compare
ludamad
requested review from
dbanks12,
fcarreiro and
sirasistant
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
msgpack-compactserialisation format noir-lang/noir#10878 which adds C++ codegen support for msgpack-compact serialization formatNOIR_SERIALIZATION_FORMAT=msgpack-compactin source_bootstrap (with WORKTODO comment to remove once it's the default)