fix: add actionable error when bb verify cannot find vk file #19398
+55
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnathan79717
requested review from
IlyasRidhuan,
Maddiaa0,
charlielye,
dbanks12,
fcarreiro,
jeanmon and
sirasistant
as code owners
johnathan79717
changed the base branch from
master
to
merge-train/barretenberg
johnathan79717
removed request for
IlyasRidhuan,
Maddiaa0,
charlielye,
dbanks12,
fcarreiro,
jeanmon and
sirasistant
When users run `bb prove` without `--write_vk` and then attempt `bb verify`, they previously got a confusing "Unable to open file: ./target/vk" error. Now the error message provides actionable guidance: "Unable to open file: ./target/vk Generate a vk during proving by running `bb prove` with an additional `--write_vk` flag, or run `bb write_vk` to generate a standalone vk. If you already have a vk file, specify its path with `--vk_path <path>`." Fixes #17726
johnathan79717
force-pushed
the
fix/actionable-vk-error-message
branch
from
f6c8a8a to
f930f19
Compare
fcarreiro
reviewed
Jan 7, 2026
ledwards2225
approved these changes
Jan 8, 2026
Contributor
ledwards2225
left a comment
ledwards2225
left a comment
There was a problem hiding this comment.
Great! thanks for taking care of this
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
BEGIN_COMMIT_OVERRIDE chore: remove round.cpp and round.hpp in dsl/acir_format (#19412) chore: docs for translator (#19056) chore: update noir/noir-repo to match next branch chore: update avm-transpiler Cargo.lock for noir submodule fix: revert noir/noir-repo to match next and update Cargo.lock fix: add actionable error when bb verify cannot find vk file (#19398) chore: `utils.cpp` audit (#19425) chore: sha audit 1 (#19072) fix: improve no artifacts found message to include search path (#19432) chore: simplify Flavors' Transcripts + VKs deduplication (#19326) Add correct VKSerializationMode to AVM VerificationKey Classes END_COMMIT_OVERRIDE
github-actions bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
## Summary - Adds a more helpful error message when `bb verify` fails because the vk file doesn't exist - Previously users got a confusing "Unable to open file: ./target/vk" error - Now the error provides actionable guidance on how to generate or specify the vk file ## Test plan - Added `VerifyWithMissingVkGivesActionableError` test that verifies the error message contains: - `--write_vk` flag guidance - `bb write_vk` command guidance - `--vk_path` option guidance Fixes #17726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
bb verifyfails because the vk file doesn't existTest plan
VerifyWithMissingVkGivesActionableErrortest that verifies the error message contains:--write_vkflag guidancebb write_vkcommand guidance--vk_pathoption guidanceFixes #17726