Skip to content

feat(avm)!: dont expose/require VK #19414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fcarreiro merged 6 commits into from
Jan 8, 2026
Merged

feat(avm)!: dont expose/require VK #19414

fcarreiro merged 6 commits into from
Jan 8, 2026

Conversation

@fcarreiro
Copy link
Contributor

@fcarreiro fcarreiro commented Jan 8, 2026 •
edited
Loading

The AVM VK is fixed and available in the binary, therefore we don't need to ask the user to provide it, and we also don't need to return it after proving. I kept the avm_get_vk CLI option since it might be useful for inspection.

Also included some cleanup and unification on the TS side.

Closes AVM-189.

@fcarreiro Graphite App
Copy link
Contributor Author

fcarreiro commented Jan 8, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fcarreiro fcarreiro changed the title refactor(avm)!: dont externalize VK feat(avm)!: dont externalize VK Jan 8, 2026
@fcarreiro fcarreiro marked this pull request as ready for review January 8, 2026 11:59
@fcarreiro fcarreiro requested review from dbanks12 and removed request for IlyasRidhuan and jeanmon January 8, 2026 11:59
@fcarreiro fcarreiro changed the title feat(avm)!: dont externalize VK feat(avm)!: dont expose VK Jan 8, 2026
@fcarreiro fcarreiro changed the title feat(avm)!: dont expose VK feat(avm)!: dont expose/require VK Jan 8, 2026
@fcarreiro fcarreiro added the ci-full Run all master checks. label Jan 8, 2026 — with Graphite App
dbanks12
dbanks12 approved these changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@fcarreiro Graphite App
Copy link
Contributor Author

fcarreiro commented Jan 8, 2026 •
edited
Loading

Merge activity

  • Jan 8, 1:58 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 8, 1:59 PM UTC: @fcarreiro merged this pull request with Graphite.

@fcarreiro fcarreiro merged commit a0bf2d3 into merge-train/avm Jan 8, 2026
17 checks passed
@fcarreiro fcarreiro deleted the fc/avm-no-vk-from-users branch January 8, 2026 13:59
@AztecBot AztecBot mentioned this pull request Jan 8, 2026
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 9, 2026
@AztecBot
feat: merge-train/avm (#19422)
2dc5653 
BEGIN_COMMIT_OVERRIDE
feat(avm)!: dont expose/require VK (#19414)
chore(avm): params should be references
chore: defensive asserts for map/vector retrievals and optional values
in cpp (#19439)
END_COMMIT_OVERRIDE
github-actions bot pushed a commit that referenced this pull request Jan 9, 2026
@fcarreiro
feat(avm)!: dont expose/require VK (#19414)
36e5f66 
The AVM VK is fixed and available in the binary, therefore we don't need to ask the user to provide it, and we also don't need to return it after proving. I kept the `avm_get_vk` CLI option since it might be useful for inspection.

Also included some cleanup and unification on the TS side.

Closes [AVM-189](https://linear.app/aztec-labs/issue/AVM-189/avm-remove-vk-from-cli-parameters).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexghr alexghr alexghr approved these changes

@dbanks12 dbanks12 dbanks12 approved these changes

Assignees

No one assigned

Labels

ci-full Run all master checks.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fcarreiro @alexghr @dbanks12